From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table
Date: Tue, 19 Jan 2010 12:25:59 +0100 [thread overview]
Message-ID: <4B5596C7.1050701@redhat.com> (raw)
In-Reply-To: <20100119105843.GB12960@lst.de>
Am 19.01.2010 11:58, schrieb Christoph Hellwig:
> On Mon, Jan 18, 2010 at 01:11:27PM +0100, Kevin Wolf wrote:
>> Return the appropriate error value instead of always using EIO. Don't free the
>> L1 table on errors, we still need it.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>
> Looks good correct, but shouldn't we free the clusters for the new l1
> table if writing to it fails? At least dependend on whether it's EIO
> in which case we could assume the sectos on disk to be worn out.
Agreed, we should try to free them. At least in RHEV, the most likely
case for failure will be ENOSPC and we're going to succeed with the free
in that case.
This will become the first patch of the second series then. ;-)
Kevin
next prev parent reply other threads:[~2010-01-19 11:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 12:11 [Qemu-devel] [PATCH 00/10] qcow2 error path fixes Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table Kevin Wolf
2010-01-19 10:58 ` Christoph Hellwig
2010-01-19 11:25 ` Kevin Wolf [this message]
2010-01-18 12:11 ` [Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate Kevin Wolf
2010-01-19 10:59 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 03/10] qcow2: Return 0/-errno in get_cluster_table Kevin Wolf
2010-01-19 11:06 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset Kevin Wolf
2010-01-19 11:35 ` Christoph Hellwig
2010-01-19 11:57 ` Kevin Wolf
2010-01-19 12:02 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 05/10] block: Return original error codes in bdrv_pread/write Kevin Wolf
2010-01-19 10:55 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 06/10] qcow2: Fix error handling in grow_refcount_table Kevin Wolf
2010-01-19 11:36 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount Kevin Wolf
2010-01-19 18:51 ` Christoph Hellwig
2010-01-20 9:47 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts Kevin Wolf
2010-01-19 18:53 ` Christoph Hellwig
2010-01-20 9:55 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 09/10] qcow2: Don't ignore update_refcount return value Kevin Wolf
2010-01-19 18:54 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters " Kevin Wolf
2010-01-19 18:58 ` Christoph Hellwig
2010-01-20 10:02 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5596C7.1050701@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).