From: Stefan Weil <weil@mail.berlios.de>
To: "Loïc Minier" <lool@dooz.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Stop using "which" in ./configure
Date: Tue, 19 Jan 2010 18:42:40 +0100 [thread overview]
Message-ID: <4B55EF10.7080502@mail.berlios.de> (raw)
In-Reply-To: <20100119114750.GB11613@bee.dooz.org>
Loïc Minier schrieb:
> On Tue, Jan 19, 2010, Loïc Minier wrote:
>
>> Following the thread on the sdl-config patch, please find attached a
>> patch to add a couple of portable shell functions which allow testing
>> whehter a command/builtin is available and to find the full pathname of
>> an executable in the PATH. This also replaces all uses of "which" in
>> ./configure. (This should be applied on top of the sdl-config patch.)
>>
>
> Please find attached a new version of the patch with a simpler version
> of path_of() which uses IFS instead of the ${foo#bar} and ${foo%%bar}
> constructs. It also removes the special casing of an empty PATH.
I did not test the whole patch, but I think this would be better:
+ type "$local_command" >/dev/null 2>&1
(type sends error messages to stderr, we don't want to see them)
next prev parent reply other threads:[~2010-01-19 17:42 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 12:45 [Qemu-devel] [PATCH] Check for sdl-config before calling it Loïc Minier
2010-01-17 13:17 ` [Qemu-devel] " Måns Rullgård
2010-01-17 13:43 ` Stefan Weil
2010-01-17 14:39 ` Måns Rullgård
2010-01-19 10:11 ` [Qemu-devel] Stop using "which" in ./configure Loïc Minier
2010-01-19 11:47 ` Loïc Minier
2010-01-19 17:42 ` Stefan Weil [this message]
2010-01-20 9:02 ` Loïc Minier
2010-01-19 18:09 ` [Qemu-devel] " Måns Rullgård
2010-01-20 11:37 ` Loïc Minier
2010-01-20 12:19 ` Paolo Bonzini
2010-01-20 13:49 ` Loïc Minier
2010-01-20 14:18 ` Paolo Bonzini
2010-01-20 16:51 ` Loïc Minier
2010-01-20 18:11 ` Måns Rullgård
2010-01-21 8:44 ` Loïc Minier
2010-01-21 9:48 ` Juan Quintela
2010-01-21 12:14 ` Måns Rullgård
2010-01-26 16:47 ` Loïc Minier
2010-01-26 19:16 ` Blue Swirl
2010-01-27 12:10 ` [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it Loïc Minier
2010-01-27 12:10 ` [Qemu-devel] [PATCH 2/3] Add and use has() and path_of() funcs Loïc Minier
2010-01-27 12:10 ` [Qemu-devel] [PATCH 3/3] Solaris: test for presence of commands with has() Loïc Minier
2010-01-27 12:47 ` [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it Ben Taylor
2010-01-27 13:02 ` [Qemu-devel] " Paolo Bonzini
2010-01-27 12:41 ` [Qemu-devel] Re: Stop using "which" in ./configure Loïc Minier
2010-01-27 17:54 ` Blue Swirl
2010-01-28 20:33 ` Loïc Minier
2010-01-28 21:30 ` Blue Swirl
2010-01-21 16:53 ` Jamie Lokier
2010-01-21 20:12 ` Paolo Bonzini
2010-01-20 12:49 ` Juan Quintela
2010-01-20 13:16 ` Paolo Bonzini
2010-01-20 13:54 ` Loïc Minier
2010-01-20 14:06 ` Loïc Minier
2010-01-17 13:36 ` [Qemu-devel] [PATCH] Check for sdl-config before calling it Stefan Weil
2010-01-17 16:06 ` Loïc Minier
2010-01-18 11:35 ` [Qemu-devel] " Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2010-01-19 10:35 [Qemu-devel] Stop using "which" in ./configure Laurent Vivier
2010-01-19 11:40 ` Loïc Minier
2010-01-19 13:58 ` Krumme, Chris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B55EF10.7080502@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=lool@dooz.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).