From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXMio-00040G-DG
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:38:50 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXMij-0003zM-JD
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:38:50 -0500
Received: from [199.232.76.173] (port=43460 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXMij-0003zH-Dj
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:38:45 -0500
Received: from qw-out-1920.google.com ([74.125.92.147]:6117)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NXMij-0004og-7w
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:38:45 -0500
Received: by qw-out-1920.google.com with SMTP id 4so44611qwk.4
	for <qemu-devel@nongnu.org>; Tue, 19 Jan 2010 14:38:44 -0800 (PST)
Message-ID: <4B563471.8080804@codemonkey.ws>
Date: Tue, 19 Jan 2010 16:38:41 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] rtl8139: fix clang reporting unused
	assignment of VLAN tagging data
References: <20100113225325.6508.46954.stgit@skyserv>
In-Reply-To: <20100113225325.6508.46954.stgit@skyserv>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Igor V. Kovalenko" <igor.v.kovalenko@gmail.com>
Cc: qemu-devel@nongnu.org

On 01/13/2010 04:53 PM, Igor V. Kovalenko wrote:
> From: Igor V. Kovalenko<igor.v.kovalenko@gmail.com>
>
> Currently we do not implement VLAN tagging for rtl8139(C+),
> still data is read from ring buffer headers.
>
> - augment unused assignment with TODO item
> - cast txdw1 to void for now
>
> Signed-off-by: Igor V. Kovalenko<igor.v.kovalenko@gmail.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   hw/rtl8139.c |    5 +++++
>   1 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/hw/rtl8139.c b/hw/rtl8139.c
> index 1f4f585..f04dd54 100644
> --- a/hw/rtl8139.c
> +++ b/hw/rtl8139.c
> @@ -1909,6 +1909,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
>
>       cpu_physical_memory_read(cplus_tx_ring_desc,    (uint8_t *)&val, 4);
>       txdw0 = le32_to_cpu(val);
> +    /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */
>       cpu_physical_memory_read(cplus_tx_ring_desc+4,  (uint8_t *)&val, 4);
>       txdw1 = le32_to_cpu(val);
>       cpu_physical_memory_read(cplus_tx_ring_desc+8,  (uint8_t *)&val, 4);
> @@ -1920,6 +1921,9 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
>              descriptor,
>              txdw0, txdw1, txbufLO, txbufHI));
>
> +    /* TODO: the following discard cast should clean clang analyzer output */
> +    (void)txdw1;
> +
>   /* w0 ownership flag */
>   #define CP_TX_OWN (1<<31)
>   /* w0 end of ring flag */
> @@ -2045,6 +2049,7 @@ static int rtl8139_cplus_transmit_one(RTL8139State *s)
>       /* update ring data */
>       val = cpu_to_le32(txdw0);
>       cpu_physical_memory_write(cplus_tx_ring_desc,    (uint8_t *)&val, 4);
> +    /* TODO: implement VLAN tagging support, VLAN tag data is read to txdw1 */
>   //    val = cpu_to_le32(txdw1);
>   //    cpu_physical_memory_write(cplus_tx_ring_desc+4,&val, 4);
>
>
>
>
>
>