From: Anthony Liguori <anthony@codemonkey.ws>
To: Kusanagi Kouichi <slash@ac.auone-net.jp>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call.
Date: Tue, 19 Jan 2010 16:38:57 -0600 [thread overview]
Message-ID: <4B563481.6000207@codemonkey.ws> (raw)
In-Reply-To: <20100114154625.732C062C03A@msa106.auone-net.jp>
On 01/14/2010 09:46 AM, Kusanagi Kouichi wrote:
> qemu_chr_open_fd() calls qemu_chr_generic_open(),
> so qemu_chr_open_tty() doesn't need to call it.
>
> Signed-off-by: Kusanagi Kouichi<slash@ac.auone-net.jp>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> qemu-char.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index b13f8d4..800ee6c 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1187,7 +1187,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
> return NULL;
> }
> chr->chr_ioctl = tty_serial_ioctl;
> - qemu_chr_generic_open(chr);
> return chr;
> }
> #else /* ! __linux__&& ! __sun__ */
>
prev parent reply other threads:[~2010-01-19 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 15:46 [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call Kusanagi Kouichi
2010-01-19 22:38 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B563481.6000207@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=slash@ac.auone-net.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).