From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXMj3-00044H-8I
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:39:05 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXMiy-00042D-NV
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:39:04 -0500
Received: from [199.232.76.173] (port=43463 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXMiy-00042A-K2
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:39:00 -0500
Received: from qw-out-1920.google.com ([74.125.92.147]:6117)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NXMiy-0004og-FI
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:39:00 -0500
Received: by qw-out-1920.google.com with SMTP id 4so44611qwk.4
	for <qemu-devel@nongnu.org>; Tue, 19 Jan 2010 14:39:00 -0800 (PST)
Message-ID: <4B563481.6000207@codemonkey.ws>
Date: Tue, 19 Jan 2010 16:38:57 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] char: Remove redundant
	qemu_chr_generic_open() call.
References: <20100114154625.732C062C03A@msa106.auone-net.jp>
In-Reply-To: <20100114154625.732C062C03A@msa106.auone-net.jp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kusanagi Kouichi <slash@ac.auone-net.jp>
Cc: qemu-devel@nongnu.org

On 01/14/2010 09:46 AM, Kusanagi Kouichi wrote:
> qemu_chr_open_fd() calls qemu_chr_generic_open(),
> so qemu_chr_open_tty() doesn't need to call it.
>
> Signed-off-by: Kusanagi Kouichi<slash@ac.auone-net.jp>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   qemu-char.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index b13f8d4..800ee6c 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1187,7 +1187,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
>           return NULL;
>       }
>       chr->chr_ioctl = tty_serial_ioctl;
> -    qemu_chr_generic_open(chr);
>       return chr;
>   }
>   #else  /* ! __linux__&&  ! __sun__ */
>