* [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call.
@ 2010-01-14 15:46 Kusanagi Kouichi
2010-01-19 22:38 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Kusanagi Kouichi @ 2010-01-14 15:46 UTC (permalink / raw)
To: qemu-devel
qemu_chr_open_fd() calls qemu_chr_generic_open(),
so qemu_chr_open_tty() doesn't need to call it.
Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
---
qemu-char.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/qemu-char.c b/qemu-char.c
index b13f8d4..800ee6c 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -1187,7 +1187,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
return NULL;
}
chr->chr_ioctl = tty_serial_ioctl;
- qemu_chr_generic_open(chr);
return chr;
}
#else /* ! __linux__ && ! __sun__ */
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call.
2010-01-14 15:46 [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call Kusanagi Kouichi
@ 2010-01-19 22:38 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2010-01-19 22:38 UTC (permalink / raw)
To: Kusanagi Kouichi; +Cc: qemu-devel
On 01/14/2010 09:46 AM, Kusanagi Kouichi wrote:
> qemu_chr_open_fd() calls qemu_chr_generic_open(),
> so qemu_chr_open_tty() doesn't need to call it.
>
> Signed-off-by: Kusanagi Kouichi<slash@ac.auone-net.jp>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> qemu-char.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-char.c b/qemu-char.c
> index b13f8d4..800ee6c 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -1187,7 +1187,6 @@ static CharDriverState *qemu_chr_open_tty(QemuOpts *opts)
> return NULL;
> }
> chr->chr_ioctl = tty_serial_ioctl;
> - qemu_chr_generic_open(chr);
> return chr;
> }
> #else /* ! __linux__&& ! __sun__ */
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-19 22:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-14 15:46 [Qemu-devel] [PATCH] char: Remove redundant qemu_chr_generic_open() call Kusanagi Kouichi
2010-01-19 22:38 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).