From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] remove dead code from target-i386/exec.h
Date: Tue, 19 Jan 2010 16:39:56 -0600 [thread overview]
Message-ID: <4B5634BC.3020503@codemonkey.ws> (raw)
In-Reply-To: <1263542196-12842-2-git-send-email-pbonzini@redhat.com>
On 01/15/2010 01:56 AM, Paolo Bonzini wrote:
> These are unused since edea5f0 (no need to define global registers in
> cpu-exec.c, 2008-05-10).
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> target-i386/exec.h | 48 ------------------------------------------------
> 1 files changed, 0 insertions(+), 48 deletions(-)
>
> diff --git a/target-i386/exec.h b/target-i386/exec.h
> index 864d030..e8365b1 100644
> --- a/target-i386/exec.h
> +++ b/target-i386/exec.h
> @@ -292,58 +292,10 @@ static inline void load_eflags(int eflags, int update_mask)
>
> static inline void env_to_regs(void)
> {
> -#ifdef reg_EAX
> - EAX = env->regs[R_EAX];
> -#endif
> -#ifdef reg_ECX
> - ECX = env->regs[R_ECX];
> -#endif
> -#ifdef reg_EDX
> - EDX = env->regs[R_EDX];
> -#endif
> -#ifdef reg_EBX
> - EBX = env->regs[R_EBX];
> -#endif
> -#ifdef reg_ESP
> - ESP = env->regs[R_ESP];
> -#endif
> -#ifdef reg_EBP
> - EBP = env->regs[R_EBP];
> -#endif
> -#ifdef reg_ESI
> - ESI = env->regs[R_ESI];
> -#endif
> -#ifdef reg_EDI
> - EDI = env->regs[R_EDI];
> -#endif
> }
>
> static inline void regs_to_env(void)
> {
> -#ifdef reg_EAX
> - env->regs[R_EAX] = EAX;
> -#endif
> -#ifdef reg_ECX
> - env->regs[R_ECX] = ECX;
> -#endif
> -#ifdef reg_EDX
> - env->regs[R_EDX] = EDX;
> -#endif
> -#ifdef reg_EBX
> - env->regs[R_EBX] = EBX;
> -#endif
> -#ifdef reg_ESP
> - env->regs[R_ESP] = ESP;
> -#endif
> -#ifdef reg_EBP
> - env->regs[R_EBP] = EBP;
> -#endif
> -#ifdef reg_ESI
> - env->regs[R_ESI] = ESI;
> -#endif
> -#ifdef reg_EDI
> - env->regs[R_EDI] = EDI;
> -#endif
> }
>
> static inline int cpu_has_work(CPUState *env)
>
next prev parent reply other threads:[~2010-01-19 22:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 7:56 [Qemu-devel] [PATCH 0/3] cleanup cpu_exec 1/n Paolo Bonzini
2010-01-15 7:56 ` [Qemu-devel] [PATCH 1/3] remove dead code from target-i386/exec.h Paolo Bonzini
2010-01-15 14:54 ` Tristan Gingold
2010-01-15 15:12 ` Paolo Bonzini
2010-01-19 22:39 ` Anthony Liguori [this message]
2010-01-15 7:56 ` [Qemu-devel] [PATCH 2/3] kill regs_to_env and env_to_regs Paolo Bonzini
2010-01-15 7:56 ` [Qemu-devel] [PATCH 3/3] fix wrong indentation Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5634BC.3020503@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).