From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXMk7-0004YL-5b for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:40:11 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXMk1-0004XV-QQ for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:40:10 -0500 Received: from [199.232.76.173] (port=43481 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXMk1-0004XS-Kh for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:40:05 -0500 Received: from qw-out-1920.google.com ([74.125.92.150]:7960) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXMk1-0004su-E0 for qemu-devel@nongnu.org; Tue, 19 Jan 2010 17:40:05 -0500 Received: by qw-out-1920.google.com with SMTP id 4so44911qwk.4 for ; Tue, 19 Jan 2010 14:40:05 -0800 (PST) Message-ID: <4B5634BC.3020503@codemonkey.ws> Date: Tue, 19 Jan 2010 16:39:56 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] remove dead code from target-i386/exec.h References: <1263542196-12842-1-git-send-email-pbonzini@redhat.com> <1263542196-12842-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1263542196-12842-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 01/15/2010 01:56 AM, Paolo Bonzini wrote: > These are unused since edea5f0 (no need to define global registers in > cpu-exec.c, 2008-05-10). > > Signed-off-by: Paolo Bonzini > Applied. Thanks. Regards, Anthony Liguori > --- > target-i386/exec.h | 48 ------------------------------------------------ > 1 files changed, 0 insertions(+), 48 deletions(-) > > diff --git a/target-i386/exec.h b/target-i386/exec.h > index 864d030..e8365b1 100644 > --- a/target-i386/exec.h > +++ b/target-i386/exec.h > @@ -292,58 +292,10 @@ static inline void load_eflags(int eflags, int update_mask) > > static inline void env_to_regs(void) > { > -#ifdef reg_EAX > - EAX = env->regs[R_EAX]; > -#endif > -#ifdef reg_ECX > - ECX = env->regs[R_ECX]; > -#endif > -#ifdef reg_EDX > - EDX = env->regs[R_EDX]; > -#endif > -#ifdef reg_EBX > - EBX = env->regs[R_EBX]; > -#endif > -#ifdef reg_ESP > - ESP = env->regs[R_ESP]; > -#endif > -#ifdef reg_EBP > - EBP = env->regs[R_EBP]; > -#endif > -#ifdef reg_ESI > - ESI = env->regs[R_ESI]; > -#endif > -#ifdef reg_EDI > - EDI = env->regs[R_EDI]; > -#endif > } > > static inline void regs_to_env(void) > { > -#ifdef reg_EAX > - env->regs[R_EAX] = EAX; > -#endif > -#ifdef reg_ECX > - env->regs[R_ECX] = ECX; > -#endif > -#ifdef reg_EDX > - env->regs[R_EDX] = EDX; > -#endif > -#ifdef reg_EBX > - env->regs[R_EBX] = EBX; > -#endif > -#ifdef reg_ESP > - env->regs[R_ESP] = ESP; > -#endif > -#ifdef reg_EBP > - env->regs[R_EBP] = EBP; > -#endif > -#ifdef reg_ESI > - env->regs[R_ESI] = ESI; > -#endif > -#ifdef reg_EDI > - env->regs[R_EDI] = EDI; > -#endif > } > > static inline int cpu_has_work(CPUState *env) >