From: Kevin Wolf <kwolf@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters return value
Date: Wed, 20 Jan 2010 11:02:17 +0100 [thread overview]
Message-ID: <4B56D4A9.1000004@redhat.com> (raw)
In-Reply-To: <20100119185831.GD31526@lst.de>
Am 19.01.2010 19:58, schrieb Christoph Hellwig:
> On Mon, Jan 18, 2010 at 01:11:36PM +0100, Kevin Wolf wrote:
>> @@ -55,6 +55,9 @@ int qcow2_grow_l1_table(BlockDriverState *bs, int min_size)
>>
>> /* write new table (align to cluster) */
>> new_l1_table_offset = qcow2_alloc_clusters(bs, new_l1_size2);
>> + if (new_l1_table_offset < 0) {
>> + return new_l1_table_offset;
>> + }
>
> I think the error return needs to free new_l1_table first.
Right. Actually, I have found this bug already and included the fix in
patch 11/10 which contains the fix to the problem you found with patch 1
(however, I wasn't aware any more that I introduced it myself). Maybe I
should better respin the series instead of posting patch 11 on top.
Kevin
prev parent reply other threads:[~2010-01-20 10:03 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 12:11 [Qemu-devel] [PATCH 00/10] qcow2 error path fixes Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table Kevin Wolf
2010-01-19 10:58 ` Christoph Hellwig
2010-01-19 11:25 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate Kevin Wolf
2010-01-19 10:59 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 03/10] qcow2: Return 0/-errno in get_cluster_table Kevin Wolf
2010-01-19 11:06 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset Kevin Wolf
2010-01-19 11:35 ` Christoph Hellwig
2010-01-19 11:57 ` Kevin Wolf
2010-01-19 12:02 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 05/10] block: Return original error codes in bdrv_pread/write Kevin Wolf
2010-01-19 10:55 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 06/10] qcow2: Fix error handling in grow_refcount_table Kevin Wolf
2010-01-19 11:36 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount Kevin Wolf
2010-01-19 18:51 ` Christoph Hellwig
2010-01-20 9:47 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts Kevin Wolf
2010-01-19 18:53 ` Christoph Hellwig
2010-01-20 9:55 ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 09/10] qcow2: Don't ignore update_refcount return value Kevin Wolf
2010-01-19 18:54 ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters " Kevin Wolf
2010-01-19 18:58 ` Christoph Hellwig
2010-01-20 10:02 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B56D4A9.1000004@redhat.com \
--to=kwolf@redhat.com \
--cc=hch@lst.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).