From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXaQk-0006eB-UL
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 08:17:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXaQf-0006cc-Oc
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 08:17:06 -0500
Received: from [199.232.76.173] (port=39900 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXaQf-0006cV-Gh
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 08:17:01 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33499)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1NXaQf-0006Qa-5T
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 08:17:01 -0500
Message-ID: <4B570246.8070301@redhat.com>
Date: Wed, 20 Jan 2010 14:16:54 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20100117124528.GA24106@bee.dooz.org>	<yw1xtyukyiny.fsf@unicorn.mansr.com>	<4B531406.2070904@mail.berlios.de>	<yw1xwrzgx0bb.fsf@unicorn.mansr.com>	<20100119101119.GA11358@bee.dooz.org>	<20100119114750.GB11613@bee.dooz.org>	<yw1xy6juotjq.fsf@unicorn.mansr.com>	<20100120113741.GA31679@pig.zood.org>
	<m3pr55aqkt.fsf@neno.neno>
In-Reply-To: <m3pr55aqkt.fsf@neno.neno>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Stop using "which" in ./configure
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juan Quintela <quintela@redhat.com>
Cc: =?UTF-8?B?TG/Dr2MgTWluaWVy?= <lool@dooz.org>, qemu-devel@nongnu.org

On 01/20/2010 01:49 PM, Juan Quintela wrote:
> +      if prog_exist "awk" -a \
> +         prog_exist "grep"; then

> +  if prog_exist "texi2html" -a \
> +     prog_exist "pod2man" ; then

-a is wrong here.  BTW, it's evil for test too because its precedence 
rules WRT ! and -f/-n/-z/-x/etc. are broken.

Paolo