From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXbya-0000Qq-BJ
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:56:08 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXbyZ-0000PE-5o
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:56:07 -0500
Received: from [199.232.76.173] (port=54369 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXbyY-0000Oy-Vw
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:56:07 -0500
Received: from qw-out-1920.google.com ([74.125.92.145]:55210)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NXbyY-00042e-I3
	for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:56:06 -0500
Received: by qw-out-1920.google.com with SMTP id 4so180798qwk.4
	for <qemu-devel@nongnu.org>; Wed, 20 Jan 2010 06:56:06 -0800 (PST)
Message-ID: <4B571982.5020800@codemonkey.ws>
Date: Wed, 20 Jan 2010 08:56:02 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/8] virtio: Remove duplicate macro definition
	for max. virtqueues, bump up the max
References: <1263928018-32531-1-git-send-email-amit.shah@redhat.com>
	<1263928018-32531-2-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1263928018-32531-2-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/19/2010 01:06 PM, Amit Shah wrote:
> VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
> hw/virtio.h.
>
> Also, bump up the value of the maximum allowed virtqueues to 64. This is
> in preparation to allow multiple ports per virtio-console device.
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori
> ---
>   hw/virtio.c |    2 --
>   hw/virtio.h |    2 +-
>   2 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/hw/virtio.c b/hw/virtio.c
> index fa7184a..7c020a3 100644
> --- a/hw/virtio.c
> +++ b/hw/virtio.c
> @@ -75,8 +75,6 @@ struct VirtQueue
>       void (*handle_output)(VirtIODevice *vdev, VirtQueue *vq);
>   };
>
> -#define VIRTIO_PCI_QUEUE_MAX        16
> -
>   /* virt queue functions */
>   static void virtqueue_init(VirtQueue *vq)
>   {
> diff --git a/hw/virtio.h b/hw/virtio.h
> index 3994cc9..7b2b327 100644
> --- a/hw/virtio.h
> +++ b/hw/virtio.h
> @@ -90,7 +90,7 @@ typedef struct {
>       unsigned (*get_features)(void * opaque);
>   } VirtIOBindings;
>
> -#define VIRTIO_PCI_QUEUE_MAX 16
> +#define VIRTIO_PCI_QUEUE_MAX 64
>
>   #define VIRTIO_NO_VECTOR 0xffff
>
>