From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NY0pf-0001dk-Q0
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:28:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NY0pa-0001Wt-IJ
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:28:35 -0500
Received: from [199.232.76.173] (port=37679 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NY0pZ-0001Wd-SU
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:28:30 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52666)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1NY0pZ-0005Jj-EW
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 12:28:29 -0500
Message-ID: <4B588EB5.9000507@redhat.com>
Date: Thu, 21 Jan 2010 18:28:21 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: Add help for device properties
References: <4B54B749.5080304@mail.berlios.de>	<1264024715-23417-1-git-send-email-weil@mail.berlios.de>	<m3vdevs999.fsf@blackfin.pond.sub.org>
	<m37hrbs905.fsf@blackfin.pond.sub.org>
In-Reply-To: <m37hrbs905.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 01/21/10 17:44, Markus Armbruster wrote:
> Markus Armbruster<armbru@redhat.com>  writes:
>
>>> -        fprintf(stderr, "property \"%s.%s\" not found\n",
>>> -                dev->info->name, name);

>>> +                    fprintf(stderr, "%s.%s\n", dev->info->name, props->name);
>>> +                    props++;

> One question, though: why print DRIVER.PROPNAME instead of just
> PROPNAME?  You could still put DRIVER into the heading, say "Properties
> of DRIVER:".

Probably for consistency with the error messages.

cheers,
   Gerd