From: Paolo Bonzini <pbonzini@redhat.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: "Måns Rullgård" <mans@mansr.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Stop using "which" in ./configure
Date: Thu, 21 Jan 2010 21:12:58 +0100 [thread overview]
Message-ID: <4B58B54A.3020000@redhat.com> (raw)
In-Reply-To: <20100121165357.GA26539@shareable.org>
On 01/21/2010 05:53 PM, Jamie Lokier wrote:
>> > If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe.
>> > Likewise if you set the value first.
> Remove the colon. The above will wrongly change empty IFS, which
> is not the same as unset IFS.
local_ifs would never be unset anyway, so it would never trigger.
After all, Loic's code can be considered okay as it was in the first
place (sorry). Instead, we should just make sure that no code ever
unsets IFS. I committed this recommendation to the Autoconf manual's
shell portability section, so it's not necessary to add any comment here.
Paolo
next prev parent reply other threads:[~2010-01-21 20:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 12:45 [Qemu-devel] [PATCH] Check for sdl-config before calling it Loïc Minier
2010-01-17 13:17 ` [Qemu-devel] " Måns Rullgård
2010-01-17 13:43 ` Stefan Weil
2010-01-17 14:39 ` Måns Rullgård
2010-01-19 10:11 ` [Qemu-devel] Stop using "which" in ./configure Loïc Minier
2010-01-19 11:47 ` Loïc Minier
2010-01-19 17:42 ` Stefan Weil
2010-01-20 9:02 ` Loïc Minier
2010-01-19 18:09 ` [Qemu-devel] " Måns Rullgård
2010-01-20 11:37 ` Loïc Minier
2010-01-20 12:19 ` Paolo Bonzini
2010-01-20 13:49 ` Loïc Minier
2010-01-20 14:18 ` Paolo Bonzini
2010-01-20 16:51 ` Loïc Minier
2010-01-20 18:11 ` Måns Rullgård
2010-01-21 8:44 ` Loïc Minier
2010-01-21 9:48 ` Juan Quintela
2010-01-21 12:14 ` Måns Rullgård
2010-01-26 16:47 ` Loïc Minier
2010-01-26 19:16 ` Blue Swirl
2010-01-27 12:10 ` [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it Loïc Minier
2010-01-27 12:10 ` [Qemu-devel] [PATCH 2/3] Add and use has() and path_of() funcs Loïc Minier
2010-01-27 12:10 ` [Qemu-devel] [PATCH 3/3] Solaris: test for presence of commands with has() Loïc Minier
2010-01-27 12:47 ` [Qemu-devel] [PATCH 1/3] Check for sdl-config before calling it Ben Taylor
2010-01-27 13:02 ` [Qemu-devel] " Paolo Bonzini
2010-01-27 12:41 ` [Qemu-devel] Re: Stop using "which" in ./configure Loïc Minier
2010-01-27 17:54 ` Blue Swirl
2010-01-28 20:33 ` Loïc Minier
2010-01-28 21:30 ` Blue Swirl
2010-01-21 16:53 ` Jamie Lokier
2010-01-21 20:12 ` Paolo Bonzini [this message]
2010-01-20 12:49 ` Juan Quintela
2010-01-20 13:16 ` Paolo Bonzini
2010-01-20 13:54 ` Loïc Minier
2010-01-20 14:06 ` Loïc Minier
2010-01-17 13:36 ` [Qemu-devel] [PATCH] Check for sdl-config before calling it Stefan Weil
2010-01-17 16:06 ` Loïc Minier
2010-01-18 11:35 ` [Qemu-devel] " Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2010-01-19 10:35 [Qemu-devel] Stop using "which" in ./configure Laurent Vivier
2010-01-19 18:01 ` [Qemu-devel] " Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B58B54A.3020000@redhat.com \
--to=pbonzini@redhat.com \
--cc=jamie@shareable.org \
--cc=mans@mansr.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).