From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NY3P0-00033g-1a
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 15:13:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NY3Ov-0002xp-Qj
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 15:13:13 -0500
Received: from [199.232.76.173] (port=56620 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NY3Ov-0002xL-Do
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 15:13:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36712)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <pbonzini@redhat.com>) id 1NY3Ov-0003v4-3u
	for qemu-devel@nongnu.org; Thu, 21 Jan 2010 15:13:09 -0500
Message-ID: <4B58B54A.3020000@redhat.com>
Date: Thu, 21 Jan 2010 21:12:58 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <yw1xwrzgx0bb.fsf@unicorn.mansr.com>	<20100119101119.GA11358@bee.dooz.org>	<20100119114750.GB11613@bee.dooz.org>	<yw1xy6juotjq.fsf@unicorn.mansr.com>	<20100120113741.GA31679@pig.zood.org>
	<hj6sbl$hgb$1@ger.gmane.org>	<20100120134940.GA547@pig.zood.org>
	<hj73cd$aie$1@ger.gmane.org>	<20100120165103.GA3303@pig.zood.org>	<yw1xljfsmyt2.fsf@unicorn.mansr.com>
	<20100121165357.GA26539@shareable.org>
In-Reply-To: <20100121165357.GA26539@shareable.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: Stop using "which" in ./configure
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jamie Lokier <jamie@shareable.org>
Cc: =?ISO-8859-1?Q?M=E5ns_Rullg=E5rd?= <mans@mansr.com>, qemu-devel@nongnu.org

On 01/21/2010 05:53 PM, Jamie Lokier wrote:
>> >  If you make that IFS=${local_ifs:-$(printf ' \t\n')} it should be safe.
>> >  Likewise if you set the value first.
> Remove the colon.  The above will wrongly change empty IFS, which
> is not the same as unset IFS.

local_ifs would never be unset anyway, so it would never trigger.

After all, Loic's code can be considered okay as it was in the first 
place (sorry).  Instead, we should just make sure that no code ever 
unsets IFS.  I committed this recommendation to the Autoconf manual's 
shell portability section, so it's not necessary to add any comment here.

Paolo