From: Gerd Hoffmann <kraxel@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: John Cooper <john.cooper@redhat.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/4] Load global config files by default
Date: Fri, 22 Jan 2010 11:33:48 +0100 [thread overview]
Message-ID: <4B597F0C.4040003@redhat.com> (raw)
In-Reply-To: <1264099733-29666-3-git-send-email-aliguori@us.ibm.com>
On 01/21/10 19:48, Anthony Liguori wrote:
> The ordering is a little troubling. Command line options are parsed before
> loading the default configs which means that the command line configs will be
> loaded before the default config. The effect is that the default config will
> override -readconfig directives.
>
> It's unclear the best way to handle this.
Maybe we need two passes over the command line options?
-confdir and -nodefconfig switches would be handled in the first pass,
then read the global config files (unless disabled), then the second pass.
I think we could also make the default device handling less messy that
way by checking -nographic and -nodefaults in the first pass too.
Having the machine type (-M) read in the first pass could allow some
cleanups too.
cheers,
Gerd
next prev parent reply other threads:[~2010-01-22 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 18:48 [Qemu-devel] [PATCH 0/4] Introduce global config and default devices Anthony Liguori
2010-01-21 18:48 ` [Qemu-devel] [PATCH 1/4] Support --confdir in configure to specify path to configuration files Anthony Liguori
2010-01-22 12:43 ` [Qemu-devel] " Paolo Bonzini
2010-01-22 14:39 ` Anthony Liguori
2010-01-21 18:48 ` [Qemu-devel] [PATCH 2/4] Load global config files by default Anthony Liguori
2010-01-22 10:33 ` Gerd Hoffmann [this message]
2010-01-21 18:48 ` [Qemu-devel] [PATCH 3/4] Add -defaults option to allow default devices to be overridden Anthony Liguori
2010-01-22 10:15 ` Markus Armbruster
2010-01-22 15:45 ` Anthony Liguori
2010-01-21 18:48 ` [Qemu-devel] [PATCH 4/4] Allow default network type " Anthony Liguori
2010-01-22 11:00 ` [Qemu-devel] " Gerd Hoffmann
2010-01-22 14:44 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B597F0C.4040003@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=john.cooper@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).