From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NYGq1-0004lO-EK for qemu-devel@nongnu.org; Fri, 22 Jan 2010 05:34:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NYGpw-0004f5-C8 for qemu-devel@nongnu.org; Fri, 22 Jan 2010 05:34:00 -0500 Received: from [199.232.76.173] (port=32796 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYGpw-0004ew-7P for qemu-devel@nongnu.org; Fri, 22 Jan 2010 05:33:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:4830) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NYGpv-0004Du-O0 for qemu-devel@nongnu.org; Fri, 22 Jan 2010 05:33:56 -0500 Message-ID: <4B597F0C.4040003@redhat.com> Date: Fri, 22 Jan 2010 11:33:48 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1264099733-29666-1-git-send-email-aliguori@us.ibm.com> <1264099733-29666-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1264099733-29666-3-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/4] Load global config files by default List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: John Cooper , qemu-devel@nongnu.org On 01/21/10 19:48, Anthony Liguori wrote: > The ordering is a little troubling. Command line options are parsed before > loading the default configs which means that the command line configs will be > loaded before the default config. The effect is that the default config will > override -readconfig directives. > > It's unclear the best way to handle this. Maybe we need two passes over the command line options? -confdir and -nodefconfig switches would be handled in the first pass, then read the global config files (unless disabled), then the second pass. I think we could also make the default device handling less messy that way by checking -nographic and -nodefaults in the first pass too. Having the machine type (-M) read in the first pass could allow some cleanups too. cheers, Gerd