From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, avi@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support
Date: Fri, 22 Jan 2010 12:00:36 -0600 [thread overview]
Message-ID: <4B59E7C4.2050201@codemonkey.ws> (raw)
In-Reply-To: <1264108180-3666-1-git-send-email-lcapitulino@redhat.com>
On 01/21/2010 03:09 PM, Luiz Capitulino wrote:
> """
> {"QMP": {"capabilities": ["async messages"]}}
>
> { "execute": "query-qmp-mode" }
> {"return": {"mode": "handshake"}}
>
> { "execute": "change", "arguments": { "device": "vnc", "target": "password", "arg": "1234" } }
> {"error": {"class": "QMPInvalidModeCommad", "desc": "The issued command is invalid in this mode", "data": {}}}
>
> { "execute": "async_msg_enable", "arguments": { "name": "STOP" } }
> {"return": {}}
>
Maybe:
enable-capability "async messages"
disable-capability "async messages"
I think that's a bit more obvious and it means that a client doesn't
have to maintain a mapping of features -> enable functions. It's also
strange to use an enable command to disable something.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-22 18:00 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 21:09 [Qemu-devel] [RFC 00/11]: QMP feature negotiation support Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 01/11] QMP: Initial mode-oriented bits Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 02/11] QMP: Introduce 'query-qmp-mode' command Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 03/11] QError: Add QMP mode-oriented errors Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 04/11] QMP: Introduce qmp_switch_mode command Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 05/11] QMP: advertise asynchronous messages Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 06/11] QMP: Array-based async messages Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 07/11] QError: New QERR_ASYNC_MSG_NOT_FOUND Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support Luiz Capitulino
2010-01-22 18:05 ` Anthony Liguori
2010-01-22 20:09 ` Luiz Capitulino
2010-01-22 23:14 ` Anthony Liguori
2010-01-25 14:29 ` Markus Armbruster
2010-01-25 14:33 ` Avi Kivity
2010-01-25 15:11 ` Luiz Capitulino
2010-01-24 10:34 ` Avi Kivity
2010-01-24 11:07 ` Jamie Lokier
2010-01-24 15:35 ` Anthony Liguori
2010-01-24 18:35 ` Jamie Lokier
2010-01-25 11:49 ` Luiz Capitulino
2010-01-25 14:15 ` Markus Armbruster
2010-01-25 14:22 ` Luiz Capitulino
2010-01-24 14:04 ` Anthony Liguori
2010-01-24 14:17 ` Avi Kivity
2010-01-24 14:19 ` Anthony Liguori
2010-01-25 12:02 ` Luiz Capitulino
2010-01-24 10:36 ` [Qemu-devel] " Avi Kivity
2010-01-25 13:14 ` Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 09/11] Monitor: Introduce find_info_cmd() Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 10/11] QError: New QERR_QMP_INVALID_MODE_COMMAND Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 11/11] QMP: Enable feature negotiation support Luiz Capitulino
2010-01-22 10:21 ` [Qemu-devel] [RFC 00/11]: QMP " Markus Armbruster
2010-01-22 12:09 ` Luiz Capitulino
2010-01-22 14:00 ` Markus Armbruster
2010-01-22 18:00 ` Anthony Liguori [this message]
2010-01-25 14:33 ` Markus Armbruster
2010-01-26 11:53 ` Luiz Capitulino
2010-01-26 12:57 ` Jamie Lokier
2010-01-26 13:45 ` Luiz Capitulino
2010-01-26 14:29 ` Daniel P. Berrange
2010-01-26 15:57 ` Jamie Lokier
2010-01-26 16:21 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B59E7C4.2050201@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).