From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NYNoJ-0005XI-Cc
	for qemu-devel@nongnu.org; Fri, 22 Jan 2010 13:00:43 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NYNoI-0005WM-KA
	for qemu-devel@nongnu.org; Fri, 22 Jan 2010 13:00:43 -0500
Received: from [199.232.76.173] (port=54336 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NYNoI-0005W3-ER
	for qemu-devel@nongnu.org; Fri, 22 Jan 2010 13:00:42 -0500
Received: from qw-out-1920.google.com ([74.125.92.147]:16571)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NYNoI-0001pf-27
	for qemu-devel@nongnu.org; Fri, 22 Jan 2010 13:00:42 -0500
Received: by qw-out-1920.google.com with SMTP id 5so235994qwc.4
	for <qemu-devel@nongnu.org>; Fri, 22 Jan 2010 10:00:41 -0800 (PST)
Message-ID: <4B59E7C4.2050201@codemonkey.ws>
Date: Fri, 22 Jan 2010 12:00:36 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC 00/11]: QMP feature negotiation support
References: <1264108180-3666-1-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1264108180-3666-1-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, avi@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com

On 01/21/2010 03:09 PM, Luiz Capitulino wrote:
> """
> {"QMP": {"capabilities": ["async messages"]}}
>
> { "execute": "query-qmp-mode" }
> {"return": {"mode": "handshake"}}
>
> { "execute": "change", "arguments": { "device": "vnc", "target": "password", "arg": "1234" } }
> {"error": {"class": "QMPInvalidModeCommad", "desc": "The issued command is invalid in this mode", "data": {}}}
>
> { "execute": "async_msg_enable", "arguments": { "name": "STOP" } }
> {"return": {}}
>    

Maybe:

enable-capability "async messages"
disable-capability "async messages"

I think that's a bit more obvious and it means that a client doesn't 
have to maintain a mapping of features -> enable functions.  It's also 
strange to use an enable command to disable something.

Regards,

Anthony Liguori