From: Jan Kiszka <jan.kiszka@web.de>
To: Anthony Liguori <aliguori@us.ibm.com>, malc <av1474@comtv.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>,
ondrej drbohlav <ondrej.drbohlav@gmail.com>
Subject: [Qemu-devel] Re: [PATCH] Musicpal: Fix wm8750 I2C address
Date: Sun, 24 Jan 2010 09:52:05 +0100 [thread overview]
Message-ID: <4B5C0A35.9050307@web.de> (raw)
In-Reply-To: <4B5B371A.5030408@web.de>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Jan Kiszka wrote:
> Commit b3a219883e uncovered that we attached the Wolfson with an I2C
> address shifted left by one. Fixing this makes sound work again for
> the Musicpal.
Please merge into stable as well so that 0.12.3 will have a working
Musicpal again.
Thanks,
Jan
>
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> hw/musicpal.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 4a33e28..e424a7d 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -67,7 +67,7 @@
> #define MP_AUDIO_IRQ 30
>
> /* Wolfson 8750 I2C address */
> -#define MP_WM_ADDR 0x34
> +#define MP_WM_ADDR 0x1A
>
> /* Ethernet register offsets */
> #define MP_ETH_SMIR 0x010
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2010-01-24 8:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 17:51 [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address Jan Kiszka
2010-01-24 8:52 ` Jan Kiszka [this message]
2010-01-26 22:21 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5C0A35.9050307@web.de \
--to=jan.kiszka@web.de \
--cc=aliguori@us.ibm.com \
--cc=av1474@comtv.ru \
--cc=ondrej.drbohlav@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).