From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZ07y-0000op-75 for qemu-devel@nongnu.org; Sun, 24 Jan 2010 05:55:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZ07t-0000oQ-7j for qemu-devel@nongnu.org; Sun, 24 Jan 2010 05:55:33 -0500 Received: from [199.232.76.173] (port=42372 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZ07s-0000oM-UR for qemu-devel@nongnu.org; Sun, 24 Jan 2010 05:55:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43551) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZ07s-0007ZJ-E5 for qemu-devel@nongnu.org; Sun, 24 Jan 2010 05:55:28 -0500 Message-ID: <4B5C271C.4050103@redhat.com> Date: Sun, 24 Jan 2010 12:55:24 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [RFC] New API for asynchronous monitor commands References: <1264187031.2861.13.camel@aglitke> <4B5A3207.5030105@codemonkey.ws> In-Reply-To: <4B5A3207.5030105@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Luiz Capitulino , Markus Armbruster , Adam Litke On 01/23/2010 01:17 AM, Anthony Liguori wrote: > > I like this a lot and I'd like to see us remove cmd_new in place of > cmd_async. The conversion is pretty easy since we just have to add a > cb(ret_data) to the end of synchronous functions. > > Luiz/Markus/Avi, what do ya'll think? > Looks reasonable to me, minor nit about the implementation will be posted as a reply. -- error compiling committee.c: too many arguments to function