From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZ3JC-0000LF-Dy for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:19:22 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZ3J8-0000K9-3P for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:19:22 -0500 Received: from [199.232.76.173] (port=51870 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZ3J7-0000K6-RR for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:19:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54693) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZ3J7-000883-M5 for qemu-devel@nongnu.org; Sun, 24 Jan 2010 09:19:17 -0500 Message-ID: <4B5C56E2.3050602@redhat.com> Date: Sun, 24 Jan 2010 16:19:14 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC] New API for asynchronous monitor commands References: <1264187031.2861.13.camel@aglitke> <4B5C2811.8060408@redhat.com> <4B5C52B8.6050900@codemonkey.ws> In-Reply-To: <4B5C52B8.6050900@codemonkey.ws> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Luiz Capitulino , qemu-devel@nongnu.org, Adam Litke On 01/24/2010 04:01 PM, Anthony Liguori wrote: >> Instead of sending opaques everywhere (and having them correspond to >> different types in different cases), I would prefer it if the handle >> always accepted an AsyncCommandCompletion *. That makes it easier to >> follow the code, since there are no opaques you have to guess the >> true type of. > > > I agree with you in principle but the model of passing (function > pointer, opaque) is pervasive within QEMU. I'd prefer consistency > here and if we want to switch to something more like a function > object, we do it globally. At least some recent code has moved in this direction (together with container_of()), but I don't think there's a reason to press this issue now. -- error compiling committee.c: too many arguments to function