From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZ4Iw-0003Lc-UC
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 10:23:10 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZ4Is-0003Ho-Jr
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 10:23:10 -0500
Received: from [199.232.76.173] (port=53875 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZ4Is-0003Hf-9j
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 10:23:06 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:42674)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NZ4Is-0005Lo-Ab
	for qemu-devel@nongnu.org; Sun, 24 Jan 2010 10:23:06 -0500
Received: by yxe26 with SMTP id 26so2261466yxe.4
	for <qemu-devel@nongnu.org>; Sun, 24 Jan 2010 07:23:05 -0800 (PST)
Message-ID: <4B5C65D7.5040304@codemonkey.ws>
Date: Sun, 24 Jan 2010 09:23:03 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH 1/3] Support --sysconfdir in configure
	to specify path to configuration files (v3)
References: <1264342938-7363-1-git-send-email-aliguori@us.ibm.com>	<1264342938-7363-2-git-send-email-aliguori@us.ibm.com>
	<hjhme7$ht7$1@ger.gmane.org>
In-Reply-To: <hjhme7$ht7$1@ger.gmane.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/24/2010 08:45 AM, Paolo Bonzini wrote:
> On 01/24/2010 03:22 PM, Anthony Liguori wrote:
>> The default value is ${prefix}/etc/qemu.  --sysconfdir can be used to 
>> override
>> the default to an absolute path.  The expectation is that when 
>> installed to
>> /usr, --sysconfdir=/etc/qemu will be used.
>>
>> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>> ---
>> v2 ->  v3
>>   - default sysconfdir to ${prefix}/etc on unix, ${prefix} on win32
>>   - set confdir to ${sysconfdir}/qemu on unix, ${sysconfdir} on win32
>
> I'm not sure about the choice for Windows.  Do we want possibly a 
> dozen of .conf files all in the same directory as the binaries, or 
> maybe it's better to set sysconfdir = ${prefix}/conf, 
> confdir=${sysconfdir} on Windows?

I honestly don't know.  What's the normal thing to do with Windows?

>
>> +if test "$mingw32" = "yes" ; then
>> +  echo "CONFIG_QEMU_CONFDIR=\"$sysconfdir\"" >> $config_host_mak
>> +else
>> +  echo "CONFIG_QEMU_CONFDIR=\"${sysconfdir}/qemu\"" >> $config_host_mak
>> +fi
>
> Also, here you can use $confsuffix as used a bit above to avoid 
> introducing an if here.
>
> Anyway, this can be discussed/cleaned up later, this patch gets my ack.

Regards,

Anthony Liguori

> Paolo
>
>
>