From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZSVX-0001uX-7Q
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:13:47 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZSVS-0001ok-2s
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:13:46 -0500
Received: from [199.232.76.173] (port=34767 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZSVR-0001oV-TQ
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:13:41 -0500
Received: from mx1.redhat.com ([209.132.183.28]:22767)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1NZSVR-0000h9-GG
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:13:41 -0500
Message-ID: <4B5DD13F.5060105@redhat.com>
Date: Mon, 25 Jan 2010 18:13:35 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <4B5DCAF2.3010105@redhat.com> <4B5DCB93.7050007@redhat.com>
	<4B5DCC53.508@redhat.com>
	<2CE27313-0F43-4A93-905F-3DF4815BC0B5@suse.de>
In-Reply-To: <2CE27313-0F43-4A93-905F-3DF4815BC0B5@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through
	qemu_cfg
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Kevin O'Connor <kevin@koconnor.net>, QEMU Developers <qemu-devel@nongnu.org>, KVM General <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

On 01/25/10 17:58, Alexander Graf wrote:
> Howdy. Congratulations to the new mail address - looks neat ;-).

:-)

> Two comments:
>
> 1) I don't see how passing a single region is any help. I'd rather like to see a device tree like table structure
> You'd get one variable for len of the table, one with the contents. So for a universal reserved region specifier you'd get:
>
> <u64 base><u64 len>
>
> Then have len=2 and put data in the table:
>
> <u64 base1><u64 len1><u64 base2><u64 len2>
>
> That way we'd get 2 entries and the chance to enhance them later on. In fact, it might even make sense to pass the whole table in such a form. That way qemu generates all of the e820 tables and we can declare whatever we want. Just add a type field in the table.

I am fine with having QEMU build the e820 tables completely if there is
a consensus to take that path.

> 2) Please inline patches. They showed up as attachments here, making them really hard to comment on.

Sorry Thunderbug doesn't do that well, but they should be attached as
txt?

Cheers,
Jes