From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZT11-0006tW-2c
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:46:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZT0w-0006ky-8v
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:46:18 -0500
Received: from [199.232.76.173] (port=52103 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZT0w-0006ko-3e
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:46:14 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28784)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1NZT0v-0005lv-EQ
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 12:46:13 -0500
Message-ID: <4B5DD8DE.7050100@redhat.com>
Date: Mon, 25 Jan 2010 18:46:06 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <4B5DCAF2.3010105@redhat.com> <4B5DCB93.7050007@redhat.com>
	<4B5DCC53.508@redhat.com>
	<2CE27313-0F43-4A93-905F-3DF4815BC0B5@suse.de>
	<4B5DD13F.5060105@redhat.com>
	<04C75D06-9153-410E-8D91-474F2A92D265@suse.de>
In-Reply-To: <04C75D06-9153-410E-8D91-474F2A92D265@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] QEMU - provide e820 reserve through
	qemu_cfg
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, Kevin O'Connor <kevin@koconnor.net>, QEMU Developers <qemu-devel@nongnu.org>, KVM General <kvm@vger.kernel.org>, Avi Kivity <avi@redhat.com>

On 01/25/10 18:28, Alexander Graf wrote:
>>> That way we'd get 2 entries and the chance to enhance them later on.
>>> In fact, it might even make sense to pass the whole table in such a
>>> form. That way qemu generates all of the e820 tables and we can
>>> declare whatever we want. Just add a type field in the table.
>>
>> I am fine with having QEMU build the e820 tables completely if there is
>> a consensus to take that path.
>
> I agree. We better get this right :-). I don't want to maintain 5
> versions of an 380 fw_cfg interface.

Looking at the internals, some of the e820 entries are based on compile
time constants for the BIOS, so it will be hard to pass those from
QEMU, but we could do it in a way so we pass a number of additional
e820 entries. Ie. address, length, and type.

What do you think?

Cheers,
Jes