From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZUXk-0002aO-2K
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:24:12 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZUXf-0002VA-AT
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:24:11 -0500
Received: from [199.232.76.173] (port=33721 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZUXe-0002Um-Vz
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:24:07 -0500
Received: from moutng.kundenserver.de ([212.227.17.9]:52139)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1NZUXe-0008RV-At
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:24:06 -0500
Message-ID: <4B5DEFAA.5000601@mail.berlios.de>
Date: Mon, 25 Jan 2010 20:23:22 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld
References: <1264368221-3040-1-git-send-email-hpoussin@reactos.org>
	<20100125100905.GA9019@redhat.com>
	<4B5DD596.4040503@mail.berlios.de>
	<20100125174756.GB11998@redhat.com>
In-Reply-To: <20100125174756.GB11998@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Herve Poussineau <hpoussin@reactos.org>, qemu-devel@nongnu.org, lcapitulino@redhat.com

Michael S. Tsirkin schrieb:
> On Mon, Jan 25, 2010 at 06:32:06PM +0100, Stefan Weil wrote:
>> Michael S. Tsirkin schrieb:
>>> On Sun, Jan 24, 2010 at 09:23:41PM +0000, Herve Poussineau wrote:
>>>> Replace %lld occurrences by PRId64.
>>> This is wrong.
>>> long long values should be printed with %lld.
>>> size_t - with %zd. PRId64 is for int64_t.
>>>
>> size_t => %zu, ssize_t => %zd might be better.
>>
>> And none of them works on win32, so using them
>> there can result in a crash:
>>
>> size_t st = 4711;
>> fprintf(stderr, "st=%zu, %s\n", st, "test");
>>
>> printf functions on win32 don't know %z.
>> They run
>>
>> fprintf(stderr, "st=zu, %s\n", st, "test");
>>
>> which results in an memory access fault when printf
>> wants to read the memory at address 0x4711.
>>
>> Regards,
>> Stefan Weil
>
> Let's just implement a compliant printf?

Or format the harddisk and install linux?
Maybe that would be the better option :-)

Of course you can add a printf to qemu, or to mingw32.
No need to implement it - there are lots of good free
implementations.

The mingw developers are aware of the problem
(http://www.mail-archive.com/mingw-w64-public@lists.sourceforge.net/msg00416.html).

If there is an easy solution, they will fix the problem.

I don't think the problem can be fixed easy:
there is not only printf but a lot of functions which use
format strings. They are implemented in msvcrt.dll.
Replacing single functions in a dll is difficult.
Telling code which printf in which dll is the correct
one is difficult, too.

There are easy solutions for QEMU: type cast
size_t values to unsigned or uint32_t in printf
or use a new macro (for example PRIsize) in
format strings. That macro would be different for
mingw32 and standard conforming systems.