From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZUok-0002tG-3Z
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:41:46 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZUof-0002rB-6E
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:41:45 -0500
Received: from [199.232.76.173] (port=39692 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZUof-0002r5-1E
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:41:41 -0500
Received: from moutng.kundenserver.de ([212.227.17.8]:62290)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <weil@mail.berlios.de>) id 1NZUoe-00028v-FT
	for qemu-devel@nongnu.org; Mon, 25 Jan 2010 14:41:40 -0500
Message-ID: <4B5DF3D5.5080101@mail.berlios.de>
Date: Mon, 25 Jan 2010 20:41:09 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld
References: <1264368221-3040-1-git-send-email-hpoussin@reactos.org>
	<20100125100905.GA9019@redhat.com>
	<4B5DD596.4040503@mail.berlios.de>
In-Reply-To: <4B5DD596.4040503@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Herve Poussineau <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>

Stefan Weil schrieb:
> Michael S. Tsirkin schrieb:
>> On Sun, Jan 24, 2010 at 09:23:41PM +0000, Herve Poussineau wrote:
>>> Replace %lld occurrences by PRId64.
>> This is wrong.
>> long long values should be printed with %lld.
>> size_t - with %zd. PRId64 is for int64_t.
>>
>
> size_t => %zu, ssize_t => %zd might be better.
>
> And none of them works on win32, so using them
> there can result in a crash:
>
> size_t st = 4711;
> fprintf(stderr, "st=%zu, %s\n", st, "test");
>
> printf functions on win32 don't know %z.
> They run
>
> fprintf(stderr, "st=zu, %s\n", st, "test");
>
> which results in an memory access fault when printf
> wants to read the memory at address 0x4711.
>
> Regards,
> Stefan Weil
>
>

Hi,

I just read this which could explain crashes with %lld:

/* MSVCRT supports additional length specifiers for "printf". (In
fact, it does not support some of the C99 specifiers, like
"ll". However, we do not presently have a mechanism for disabling
a specifier.) */

A short test:
    long long ll = 0;
    printf("ll=%lld, string=%s\n", ll, "test");

ll=0, string=(null)

=> You can crash QEMU for win32 with %lld.

Regards,
Stefan