From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZltW-0004E3-AM for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:55:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZltR-00049m-BF for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:55:49 -0500 Received: from [199.232.76.173] (port=51146 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZltR-00049Y-0t for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:55:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33219) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZltQ-0004rb-Eq for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:55:44 -0500 Message-ID: <4B5EF45B.30001@redhat.com> Date: Tue, 26 Jan 2010 15:55:39 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH] win32: use PRId64 instead of %lld References: <1264368221-3040-1-git-send-email-hpoussin@reactos.org> <20100125100905.GA9019@redhat.com> <20100125120348.461ce622@doriath> <20100125132719.23a483cf@doriath> <20100125153838.GB11161@redhat.com> <20100126094329.70719b6f@doriath> <4B5EE450.9090004@linux.vnet.ibm.com> In-Reply-To: <4B5EE450.9090004@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Markus Armbruster , "Michael S. Tsirkin" , Herve Poussineau , qemu-devel@nongnu.org, Luiz Capitulino On 01/26/2010 02:47 PM, Anthony Liguori wrote: > On 01/26/2010 05:43 AM, Luiz Capitulino wrote: >>> The issue I see isn't related to unsigned. Apparently we currently >>> accept values such as 'a' as valid strings. Since this is not valid >>> json >>> we probably should reject it just in case we will want to switch to >>> another json library, otherwise clients might come to depend on >>> non-standard behaviour. >> This extension is only used internally by QEMU and we find it >> very convenient otherwise we would have to escape strings in >> dicts and lists, which is error prone and time consuming. > > Actually, I was reading the JSON RFC last night and came across: > > "A JSON parser transforms a JSON text into another representation. A > JSON parser MUST accept all texts that conform to the JSON grammar. > A JSON parser MAY accept non-JSON forms or extensions." > > So we are fully JSON compliant in our current implementation. > The risk is that if we support a private extension (like '') and then json is officially extended to support a conflicting or similar syntax with a different meaning, then we cannot advance to the next revision of json without breaking compatibility. In the case of '', the odds of a such a clash are very low, but nevertheless I think we should refrain from doing so. Being strict is good. -- error compiling committee.c: too many arguments to function