From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZssp-0001G7-0K
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:23:35 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZssj-0001EO-Nm
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:23:33 -0500
Received: from [199.232.76.173] (port=57253 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZssj-0001EL-II
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:23:29 -0500
Received: from mail-iw0-f188.google.com ([209.85.223.188]:63899)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NZssj-00058U-GH
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:23:29 -0500
Received: by iwn26 with SMTP id 26so5330766iwn.14
	for <qemu-devel@nongnu.org>; Tue, 26 Jan 2010 13:23:27 -0800 (PST)
Message-ID: <4B5F5D4C.2020605@codemonkey.ws>
Date: Tue, 26 Jan 2010 15:23:24 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 6/6] monitor: convert do_cpu_set() to
	QObject, QError
References: <1263989255-13755-1-git-send-email-armbru@redhat.com>
	<1263989255-13755-7-git-send-email-armbru@redhat.com>
In-Reply-To: <1263989255-13755-7-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/20/2010 06:07 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
> ---
>   monitor.c       |    4 ++--
>   qemu-monitor.hx |    3 ++-
>   2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 816f6fd..b9166c3 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -808,11 +808,11 @@ static void do_info_cpus(Monitor *mon, QObject **ret_data)
>       *ret_data = QOBJECT(cpu_list);
>   }
>
> -static void do_cpu_set(Monitor *mon, const QDict *qdict)
> +static void do_cpu_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
>   {
>       int index = qdict_get_int(qdict, "index");
>       if (mon_set_cpu(index)<  0)
> -        monitor_printf(mon, "Invalid CPU index\n");
> +        qemu_error_new(QERR_INVALID_CPU_INDEX);
>    

Just out of curiousity, why introduce a new error verses using 
(QERR_INVALID_PARAMETER, "index")?

Regards,

Anthony Liguori