qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: kirill@shutemov.name, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 01/17] Introduce qemu_write_full()
Date: Tue, 26 Jan 2010 15:34:07 -0600	[thread overview]
Message-ID: <4B5F5FCF.80007@codemonkey.ws> (raw)
In-Reply-To: <0db812948e253db268e1f1bebcc282197e4f880a.1263944807.git.quintela@redhat.com>

On 01/19/2010 05:56 PM, Juan Quintela wrote:
> From: Kirill A. Shutemov<kirill@shutemov.name>
>
> A variant of write(2) which handles partial write.
>
> Signed-off-by: Kirill A. Shutemov<kirill@shutemov.name>
> Signed-off-by: Juan Quintela<quintela@redhat.com>
>    

Applied all.  Thanks.

Regards,

Anthony Liguori

> ---
>   osdep.c       |   27 +++++++++++++++++++++++++++
>   qemu-common.h |    1 +
>   2 files changed, 28 insertions(+), 0 deletions(-)
>
> diff --git a/osdep.c b/osdep.c
> index 1310684..09fbc99 100644
> --- a/osdep.c
> +++ b/osdep.c
> @@ -243,6 +243,33 @@ int qemu_open(const char *name, int flags, ...)
>       return ret;
>   }
>
> +/*
> + * A variant of write(2) which handles partial write.
> + *
> + * Return the number of bytes transferred.
> + * Set errno if fewer than `count' bytes are written.
> + */
> +ssize_t qemu_write_full(int fd, const void *buf, size_t count)
> +{
> +    ssize_t ret = 0;
> +    ssize_t total = 0;
> +
> +    while (count) {
> +        ret = write(fd, buf, count);
> +        if (ret<  0) {
> +            if (errno == EINTR)
> +                continue;
> +            break;
> +        }
> +
> +        count -= ret;
> +        buf += ret;
> +        total += ret;
> +    }
> +
> +    return total;
> +}
> +
>   #ifndef _WIN32
>   /*
>    * Creates a pipe with FD_CLOEXEC set on both file descriptors
> diff --git a/qemu-common.h b/qemu-common.h
> index 8630f8c..a8144cb 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -160,6 +160,7 @@ void qemu_mutex_lock_iothread(void);
>   void qemu_mutex_unlock_iothread(void);
>
>   int qemu_open(const char *name, int flags, ...);
> +ssize_t qemu_write_full(int fd, const void *buf, size_t count);
>   void qemu_set_cloexec(int fd);
>
>   #ifndef _WIN32
>    

  parent reply	other threads:[~2010-01-26 21:34 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19 23:56 [Qemu-devel] [PATCH 00/17] Fix compilation with _FORTIFY_SOURCE Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 01/17] Introduce qemu_write_full() Juan Quintela
2010-01-20  0:45   ` malc
2010-01-26 21:34   ` Anthony Liguori [this message]
2010-01-19 23:56 ` [Qemu-devel] [PATCH 02/17] force to test result for qemu_write_full() Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 03/17] posix-aio-compat.c: fix warning with _FORTIFY_SOURCE Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 04/17] block/cow.c: fix warnings " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 05/17] block/qcow.c: " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 06/17] block/vmdk.o: " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 07/17] block/vvfat.c: " Juan Quintela
2010-01-20  6:19   ` [Qemu-devel] " Kirill A. Shutemov
2010-01-20 10:33     ` Daniel P. Berrange
2010-01-20 11:09       ` Kirill A. Shutemov
2010-01-20 11:45         ` Kevin Wolf
2010-01-20 12:15           ` Markus Armbruster
2010-01-20 12:36             ` Kirill A. Shutemov
2010-01-20 13:03               ` Markus Armbruster
2010-01-20 13:08                 ` Gleb Natapov
2010-01-20 14:02                   ` Kirill A. Shutemov
2010-01-20 14:11                     ` Gleb Natapov
2010-01-20 15:00                     ` malc
2010-01-20 13:51                 ` Kirill A. Shutemov
2010-01-20 14:42                   ` Markus Armbruster
2010-01-20 16:16                   ` Jamie Lokier
2010-01-20 15:59     ` Anthony Liguori
2010-01-19 23:56 ` [Qemu-devel] [PATCH 08/17] block/qcow2.c: " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 09/17] net/slirp.c: fix warning " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 10/17] usb-linux.c: " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 11/17] vl.c: " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 12/17] monitor.c: fix warnings " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 13/17] linux-user/mmap.c: " Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 14/17] check pipe() return value Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 15/17] Enable _FORTIFY_SOURCE=2 Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 16/17] Check availavility of -fstack-protector-all Juan Quintela
2010-01-19 23:56 ` [Qemu-devel] [PATCH 17/17] mmap_frag() users only check for -1 error Juan Quintela
  -- strict thread matches above, loose matches on Subject: below --
2010-01-20 20:13 [Qemu-devel] [PATCH v2 00/17] Fix compilation with _FORTIFY_SOURCE Juan Quintela
2010-01-20 20:13 ` [Qemu-devel] [PATCH 01/17] Introduce qemu_write_full() Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5F5FCF.80007@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=kirill@shutemov.name \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).