From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 01/10] qcow2: Fix error handling in qcow2_grow_l1_table
Date: Tue, 26 Jan 2010 15:37:39 -0600 [thread overview]
Message-ID: <4B5F60A3.6010205@linux.vnet.ibm.com> (raw)
In-Reply-To: <1263996186-6623-2-git-send-email-kwolf@redhat.com>
On 01/20/2010 08:02 AM, Kevin Wolf wrote:
> Return the appropriate error value instead of always using EIO. Don't free the
> L1 table on errors, we still need it.
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>
Applied all. Thanks.
Do you think this is stable-0.12 material? Is there any reasonable
scenario where this could fix a user visible bug?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-26 21:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 14:02 [Qemu-devel] [PATCH v2 00/10] qcow2 error path fixes Kevin Wolf
2010-01-20 14:02 ` [Qemu-devel] [PATCH v2 01/10] qcow2: Fix error handling in qcow2_grow_l1_table Kevin Wolf
2010-01-26 21:37 ` Anthony Liguori [this message]
2010-01-27 8:56 ` Kevin Wolf
2010-01-20 14:02 ` [Qemu-devel] [PATCH v2 02/10] qcow2: Fix error handling in qcow_save_vmstate Kevin Wolf
2010-01-20 14:03 ` [Qemu-devel] [PATCH v2 03/10] qcow2: Return 0/-errno in get_cluster_table Kevin Wolf
2010-01-20 14:03 ` [Qemu-devel] [PATCH v2 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset Kevin Wolf
2010-01-20 14:03 ` [Qemu-devel] [PATCH v2 05/10] block: Return original error codes in bdrv_pread/write Kevin Wolf
2010-01-20 14:03 ` [Qemu-devel] [PATCH v2 06/10] qcow2: Fix error handling in grow_refcount_table Kevin Wolf
2010-01-20 14:03 ` [Qemu-devel] [PATCH v2 07/10] qcow2: Improve error handling in update_refcount Kevin Wolf
2010-01-20 14:03 ` [Qemu-devel] [PATCH v2 08/10] qcow2: Allow updating no refcounts Kevin Wolf
2010-01-20 14:03 ` [Qemu-devel] [PATCH v2 09/10] qcow2: Don't ignore update_refcount return value Kevin Wolf
2010-01-20 14:04 ` [Qemu-devel] [PATCH v2 10/10] qcow2: Don't ignore qcow2_alloc_clusters " Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5F60A3.6010205@linux.vnet.ibm.com \
--to=aliguori@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).