From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZt6w-0005ve-4u
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:38:10 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZt6q-0005tu-Mv
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:38:09 -0500
Received: from [199.232.76.173] (port=43081 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZt6q-0005tr-IA
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:38:04 -0500
Received: from e39.co.us.ibm.com ([32.97.110.160]:33150)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1NZt6q-0006Sw-50
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 16:38:04 -0500
Received: from d03relay01.boulder.ibm.com (d03relay01.boulder.ibm.com
	[9.17.195.226])
	by e39.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o0QLUXqB001712
	for <qemu-devel@nongnu.org>; Tue, 26 Jan 2010 14:30:33 -0700
Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170])
	by d03relay01.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o0QLbfi6142342
	for <qemu-devel@nongnu.org>; Tue, 26 Jan 2010 14:37:42 -0700
Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1])
	by d03av04.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP
	id o0QLbelH002813
	for <qemu-devel@nongnu.org>; Tue, 26 Jan 2010 14:37:40 -0700
Message-ID: <4B5F60A3.6010205@linux.vnet.ibm.com>
Date: Tue, 26 Jan 2010 15:37:39 -0600
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v2 01/10] qcow2: Fix error handling in
	qcow2_grow_l1_table
References: <1263996186-6623-1-git-send-email-kwolf@redhat.com>
	<1263996186-6623-2-git-send-email-kwolf@redhat.com>
In-Reply-To: <1263996186-6623-2-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/20/2010 08:02 AM, Kevin Wolf wrote:
> Return the appropriate error value instead of always using EIO. Don't free the
> L1 table on errors, we still need it.
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
>    

Applied all.  Thanks.

Do you think this is stable-0.12 material?  Is there any reasonable 
scenario where this could fix a user visible bug?

Regards,

Anthony Liguori