From: Anthony Liguori <anthony@codemonkey.ws>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fix savevm command without id or tag
Date: Tue, 26 Jan 2010 15:59:17 -0600 [thread overview]
Message-ID: <4B5F65B5.3030403@codemonkey.ws> (raw)
In-Reply-To: <20100120162634.GA15296@amt.cnet>
Applied. Thanks.
Regards,
Anthony Liguori
On 01/20/2010 10:26 AM, Marcelo Tosatti wrote:
> savevm without id or tag segfaults in:
>
> (gdb) bt
> #0 0x00007f600a83bf8a in __strcmp_sse42 () from /lib64/libc.so.6
> #1 0x00000000004745b6 in bdrv_snapshot_find (bs=<value optimized out>,
> sn_info=0x7fff996be280, name=0x0) at savevm.c:1631
> #2 0x0000000000475c80 in del_existing_snapshots (name=<value optimized out>,
> mon=<value optimized out>) at savevm.c:1654
> #3 do_savevm (name=<value optimized out>, mon=<value optimized out>)
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
>
>
> diff --git a/savevm.c b/savevm.c
> index b3bb909..2fd3de6 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -1718,7 +1718,7 @@ void do_savevm(Monitor *mon, const QDict *qdict)
> sn->vm_clock_nsec = qemu_get_clock(vm_clock);
>
> /* Delete old snapshots of the same name */
> - if (del_existing_snapshots(mon, name)< 0) {
> + if (name&& del_existing_snapshots(mon, name)< 0) {
> goto the_end;
> }
>
>
>
>
>
prev parent reply other threads:[~2010-01-26 21:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 16:26 [Qemu-devel] [PATCH] fix savevm command without id or tag Marcelo Tosatti
2010-01-20 16:45 ` Kevin Wolf
2010-01-26 21:59 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5F65B5.3030403@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).