qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ide save/restore current transfer fields
Date: Tue, 26 Jan 2010 16:02:32 -0600	[thread overview]
Message-ID: <4B5F6678.9060703@codemonkey.ws> (raw)
In-Reply-To: <1264006909-22040-1-git-send-email-quintela@redhat.com>

On 01/20/2010 11:01 AM, Juan Quintela wrote:
> From: Marcelo Tosatti<mtosatti@redhat.com>
>
> If migration takes place between write of the bmdma address register and
> write of the command register (to initiate DMA), the destination will
> not properly start the DMA op, hanging the guest:
>
> ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen
> ata1.00: cmd c8/00:16:41:00:00/00:00:00:00:00/e0 tag 0 dma 11264 in
>           res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout)
> ata1.00: status: { DRDY }
>
> Fix by sending current transfer information in the migration data.
>
> We need to update ide version to 4 for this to work.  As we don't
> have subsectios, we need to chain the update increase until
> vmstate_ide_pci (quintela)
>
> Signed-off-by: Marcelo Tosatti<mtosatti@redhat.com>
> Signed-off-by: Juan Quintela<quintela@redhat.com>
>    

Applied.  Thanks.

This is one of those nasty stable situations.  If we backport to stable, 
we fix a potentially bug but we max migration within stable impossible.  
We really ought to blacklist the old version too without an explicit 
override.

Any thoughts on how to handle this?  We at least have to record this as 
an issue.

Regards,

Anthony Liguori

  reply	other threads:[~2010-01-26 22:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-20 17:01 [Qemu-devel] [PATCH] ide save/restore current transfer fields Juan Quintela
2010-01-26 22:02 ` Anthony Liguori [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-01-20 16:22 Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5F6678.9060703@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).