From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZtUg-0005sY-Ql for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:02:42 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZtUb-0005lZ-9p for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:02:42 -0500 Received: from [199.232.76.173] (port=47962 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZtUb-0005lA-2X for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:02:37 -0500 Received: from mail-iw0-f188.google.com ([209.85.223.188]:40596) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZtUa-0000RP-H3 for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:02:36 -0500 Received: by iwn26 with SMTP id 26so5377896iwn.14 for ; Tue, 26 Jan 2010 14:02:35 -0800 (PST) Message-ID: <4B5F6678.9060703@codemonkey.ws> Date: Tue, 26 Jan 2010 16:02:32 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] ide save/restore current transfer fields References: <1264006909-22040-1-git-send-email-quintela@redhat.com> In-Reply-To: <1264006909-22040-1-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Marcelo Tosatti , qemu-devel@nongnu.org On 01/20/2010 11:01 AM, Juan Quintela wrote: > From: Marcelo Tosatti > > If migration takes place between write of the bmdma address register and > write of the command register (to initiate DMA), the destination will > not properly start the DMA op, hanging the guest: > > ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x6 frozen > ata1.00: cmd c8/00:16:41:00:00/00:00:00:00:00/e0 tag 0 dma 11264 in > res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 (timeout) > ata1.00: status: { DRDY } > > Fix by sending current transfer information in the migration data. > > We need to update ide version to 4 for this to work. As we don't > have subsectios, we need to chain the update increase until > vmstate_ide_pci (quintela) > > Signed-off-by: Marcelo Tosatti > Signed-off-by: Juan Quintela > Applied. Thanks. This is one of those nasty stable situations. If we backport to stable, we fix a potentially bug but we max migration within stable impossible. We really ought to blacklist the old version too without an explicit override. Any thoughts on how to handle this? We at least have to record this as an issue. Regards, Anthony Liguori