From: Anthony Liguori <anthony@codemonkey.ws>
To: Juan Quintela <quintela@redhat.com>
Cc: "Andreas Färber" <andreas.faerber@web.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix generation of config-host.h
Date: Tue, 26 Jan 2010 16:03:12 -0600 [thread overview]
Message-ID: <4B5F66A0.5090807@codemonkey.ws> (raw)
In-Reply-To: <1264017258-24035-1-git-send-email-quintela@redhat.com>
On 01/20/2010 01:54 PM, Juan Quintela wrote:
> This patch improves Anthony patch a6a853c86275efd89996ce59612a000c5873db5d
>
> Once there, it improves handling of object files for qemu tools
>
> cc: Andreas Färber<andreas.faerber@web.de>
> Signed-off-by: Juan Quintela<quintela@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> Makefile | 17 +++++------------
> 1 files changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 60d5c66..3848627 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -126,21 +126,14 @@ bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS)
>
> ######################################################################
>
> -qemu-img.o: qemu-img-cmds.h config-host.h
> +qemu-img.o: qemu-img-cmds.h
> +qemu-img.o qemu-tool.o qemu-nbd.o qemu-io.o: $(GENERATED_HEADERS)
>
> -obj-y = qemu-img.o qemu-tool.o $(block-obj-y) $(qobject-obj-y)
> +qemu-img$(EXESUF): qemu-img.o qemu-tool.o $(block-obj-y) $(qobject-obj-y)
>
> -qemu-img$(EXESUF): $(obj-y)
> +qemu-nbd$(EXESUF): qemu-nbd.o qemu-tool.o $(block-obj-y) $(qobject-obj-y)
>
> -obj-y = qemu-nbd.o qemu-tool.o $(block-obj-y) $(qobject-obj-y)
> -$(obj-y): $(GENERATED_HEADERS)
> -
> -qemu-nbd$(EXESUF): $(obj-y)
> -
> -obj-y = qemu-io.o qemu-tool.o cmd.o $(block-obj-y) $(qobject-obj-y)
> -$(obj-y): $(GENERATED_HEADERS)
> -
> -qemu-io$(EXESUF): $(obj-y)
> +qemu-io$(EXESUF): qemu-io.o qemu-tool.o cmd.o $(block-obj-y) $(qobject-obj-y)
>
> qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx
> $(call quiet-command,sh $(SRC_PATH)/hxtool -h< $< > $@," GEN $@")
>
prev parent reply other threads:[~2010-01-26 22:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 19:54 [Qemu-devel] [PATCH] Fix generation of config-host.h Juan Quintela
2010-01-26 22:03 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5F66A0.5090807@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=andreas.faerber@web.de \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).