From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZtVI-0006gC-Iv for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:03:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZtVD-0006Xk-C7 for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:03:19 -0500 Received: from [199.232.76.173] (port=47995 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZtVD-0006XQ-5v for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:03:15 -0500 Received: from mail-iw0-f188.google.com ([209.85.223.188]:40596) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZtVC-0000RP-S0 for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:03:14 -0500 Received: by mail-iw0-f188.google.com with SMTP id 26so5377896iwn.14 for ; Tue, 26 Jan 2010 14:03:14 -0800 (PST) Message-ID: <4B5F66A0.5090807@codemonkey.ws> Date: Tue, 26 Jan 2010 16:03:12 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Fix generation of config-host.h References: <1264017258-24035-1-git-send-email-quintela@redhat.com> In-Reply-To: <1264017258-24035-1-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org On 01/20/2010 01:54 PM, Juan Quintela wrote: > This patch improves Anthony patch a6a853c86275efd89996ce59612a000c5873db5d > > Once there, it improves handling of object files for qemu tools > > cc: Andreas Färber > Signed-off-by: Juan Quintela > Applied. Thanks. Regards, Anthony Liguori > --- > Makefile | 17 +++++------------ > 1 files changed, 5 insertions(+), 12 deletions(-) > > diff --git a/Makefile b/Makefile > index 60d5c66..3848627 100644 > --- a/Makefile > +++ b/Makefile > @@ -126,21 +126,14 @@ bt-host.o: QEMU_CFLAGS += $(BLUEZ_CFLAGS) > > ###################################################################### > > -qemu-img.o: qemu-img-cmds.h config-host.h > +qemu-img.o: qemu-img-cmds.h > +qemu-img.o qemu-tool.o qemu-nbd.o qemu-io.o: $(GENERATED_HEADERS) > > -obj-y = qemu-img.o qemu-tool.o $(block-obj-y) $(qobject-obj-y) > +qemu-img$(EXESUF): qemu-img.o qemu-tool.o $(block-obj-y) $(qobject-obj-y) > > -qemu-img$(EXESUF): $(obj-y) > +qemu-nbd$(EXESUF): qemu-nbd.o qemu-tool.o $(block-obj-y) $(qobject-obj-y) > > -obj-y = qemu-nbd.o qemu-tool.o $(block-obj-y) $(qobject-obj-y) > -$(obj-y): $(GENERATED_HEADERS) > - > -qemu-nbd$(EXESUF): $(obj-y) > - > -obj-y = qemu-io.o qemu-tool.o cmd.o $(block-obj-y) $(qobject-obj-y) > -$(obj-y): $(GENERATED_HEADERS) > - > -qemu-io$(EXESUF): $(obj-y) > +qemu-io$(EXESUF): qemu-io.o qemu-tool.o cmd.o $(block-obj-y) $(qobject-obj-y) > > qemu-img-cmds.h: $(SRC_PATH)/qemu-img-cmds.hx > $(call quiet-command,sh $(SRC_PATH)/hxtool -h< $< > $@," GEN $@") >