* [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address
@ 2010-01-23 17:51 Jan Kiszka
2010-01-24 8:52 ` [Qemu-devel] " Jan Kiszka
2010-01-26 22:21 ` [Qemu-devel] " Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2010-01-23 17:51 UTC (permalink / raw)
To: malc; +Cc: qemu-devel, ondrej drbohlav
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
Commit b3a219883e uncovered that we attached the Wolfson with an I2C
address shifted left by one. Fixing this makes sound work again for
the Musicpal.
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
---
hw/musicpal.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/musicpal.c b/hw/musicpal.c
index 4a33e28..e424a7d 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -67,7 +67,7 @@
#define MP_AUDIO_IRQ 30
/* Wolfson 8750 I2C address */
-#define MP_WM_ADDR 0x34
+#define MP_WM_ADDR 0x1A
/* Ethernet register offsets */
#define MP_ETH_SMIR 0x010
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] Musicpal: Fix wm8750 I2C address
2010-01-23 17:51 [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address Jan Kiszka
@ 2010-01-24 8:52 ` Jan Kiszka
2010-01-26 22:21 ` [Qemu-devel] " Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Jan Kiszka @ 2010-01-24 8:52 UTC (permalink / raw)
To: Anthony Liguori, malc; +Cc: qemu-devel, ondrej drbohlav
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
Jan Kiszka wrote:
> Commit b3a219883e uncovered that we attached the Wolfson with an I2C
> address shifted left by one. Fixing this makes sound work again for
> the Musicpal.
Please merge into stable as well so that 0.12.3 will have a working
Musicpal again.
Thanks,
Jan
>
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
> hw/musicpal.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 4a33e28..e424a7d 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -67,7 +67,7 @@
> #define MP_AUDIO_IRQ 30
>
> /* Wolfson 8750 I2C address */
> -#define MP_WM_ADDR 0x34
> +#define MP_WM_ADDR 0x1A
>
> /* Ethernet register offsets */
> #define MP_ETH_SMIR 0x010
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address
2010-01-23 17:51 [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address Jan Kiszka
2010-01-24 8:52 ` [Qemu-devel] " Jan Kiszka
@ 2010-01-26 22:21 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2010-01-26 22:21 UTC (permalink / raw)
To: Jan Kiszka; +Cc: qemu-devel, ondrej drbohlav
On 01/23/2010 11:51 AM, Jan Kiszka wrote:
> Commit b3a219883e uncovered that we attached the Wolfson with an I2C
> address shifted left by one. Fixing this makes sound work again for
> the Musicpal.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@web.de>
>
Applied to stable. Thanks.
Regards,
Anthony Liguori
> ---
> hw/musicpal.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 4a33e28..e424a7d 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -67,7 +67,7 @@
> #define MP_AUDIO_IRQ 30
>
> /* Wolfson 8750 I2C address */
> -#define MP_WM_ADDR 0x34
> +#define MP_WM_ADDR 0x1A
>
> /* Ethernet register offsets */
> #define MP_ETH_SMIR 0x010
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-26 22:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-23 17:51 [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address Jan Kiszka
2010-01-24 8:52 ` [Qemu-devel] " Jan Kiszka
2010-01-26 22:21 ` [Qemu-devel] " Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).