From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZtmq-0000gR-Tq for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:21:28 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZtmm-0000fs-7T for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:21:28 -0500 Received: from [199.232.76.173] (port=57584 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZtml-0000fp-L0 for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:21:23 -0500 Received: from mx20.gnu.org ([199.232.41.8]:15392) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NZtmj-0002h1-04 for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:21:23 -0500 Received: from mail-iw0-f188.google.com ([209.85.223.188]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZtmZ-0006eD-8v for qemu-devel@nongnu.org; Tue, 26 Jan 2010 17:21:11 -0500 Received: by iwn26 with SMTP id 26so5399878iwn.14 for ; Tue, 26 Jan 2010 14:21:09 -0800 (PST) Message-ID: <4B5F6ACF.3090500@codemonkey.ws> Date: Tue, 26 Jan 2010 16:21:03 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address References: <4B5B371A.5030408@web.de> In-Reply-To: <4B5B371A.5030408@web.de> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel , ondrej drbohlav On 01/23/2010 11:51 AM, Jan Kiszka wrote: > Commit b3a219883e uncovered that we attached the Wolfson with an I2C > address shifted left by one. Fixing this makes sound work again for > the Musicpal. > > Signed-off-by: Jan Kiszka > Applied to stable. Thanks. Regards, Anthony Liguori > --- > hw/musicpal.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/hw/musicpal.c b/hw/musicpal.c > index 4a33e28..e424a7d 100644 > --- a/hw/musicpal.c > +++ b/hw/musicpal.c > @@ -67,7 +67,7 @@ > #define MP_AUDIO_IRQ 30 > > /* Wolfson 8750 I2C address */ > -#define MP_WM_ADDR 0x34 > +#define MP_WM_ADDR 0x1A > > /* Ethernet register offsets */ > #define MP_ETH_SMIR 0x010 > >