From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZxLK-0000Wd-SL for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:09:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZxLG-0000UG-3i for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:09:18 -0500 Received: from [199.232.76.173] (port=59872 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZxLF-0000U8-Tb for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:09:13 -0500 Received: from mail-iw0-f188.google.com ([209.85.223.188]:51016) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZxLF-0000en-KY for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:09:13 -0500 Received: by iwn26 with SMTP id 26so5638725iwn.14 for ; Tue, 26 Jan 2010 18:09:13 -0800 (PST) Message-ID: <4B5FA045.7090404@codemonkey.ws> Date: Tue, 26 Jan 2010 20:09:09 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/6] fix a few clang warnings References: <1264547685-21129-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1264547685-21129-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 01/26/2010 05:14 PM, Paolo Bonzini wrote: > All of these should be quite uncontroversial. The vnc.c change is > not what you'd expect though (could be a real bug, so I leave the > clang warning). > I'm scratching my head quite a bit on these. Can you resend the series with commit messages that actually explain what the problem clang is reporting and why it fixes it. The vnc one is just whacky. Regards, Anthony Liguori