From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 4/6] vnc.c: warn about ignored option
Date: Tue, 26 Jan 2010 20:10:18 -0600 [thread overview]
Message-ID: <4B5FA08A.6090107@codemonkey.ws> (raw)
In-Reply-To: <1264547685-21129-5-git-send-email-pbonzini@redhat.com>
On 01/26/2010 05:14 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> vnc.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/vnc.c b/vnc.c
> index cc2a26e..9ebee09 100644
> --- a/vnc.c
> +++ b/vnc.c
> @@ -2563,6 +2563,7 @@ int vnc_display_open(DisplayState *ds, const char *display)
> reverse = 1;
> } else if (strncmp(options, "to=", 3) == 0) {
> to_port = atoi(options+3) + 5900;
> + fprintf(stderr, "qemu: warning: to= option for -vnc ignored\n");
>
If we're ignoring it, why even have the code? How did clang spot this?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-27 2:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 23:14 [Qemu-devel] [PATCH 0/6] fix a few clang warnings Paolo Bonzini
2010-01-26 23:14 ` [Qemu-devel] [PATCH 1/6] remove two dead assignments in target-i386/translate.c Paolo Bonzini
2010-01-26 23:14 ` [Qemu-devel] [PATCH 2/6] fix undefined shifts by >32 Paolo Bonzini
2010-01-26 23:14 ` [Qemu-devel] [PATCH 3/6] exec.c: dead assignments Paolo Bonzini
2010-01-26 23:14 ` [Qemu-devel] [PATCH 4/6] vnc.c: warn about ignored option Paolo Bonzini
2010-01-27 2:10 ` Anthony Liguori [this message]
2010-01-27 10:00 ` Gerd Hoffmann
2010-01-26 23:14 ` [Qemu-devel] [PATCH 5/6] usb-linux.c: remove write-only variable Paolo Bonzini
2010-01-26 23:14 ` [Qemu-devel] [PATCH 6/6] fix audio_bug related failures Paolo Bonzini
2010-01-27 2:10 ` Anthony Liguori
2010-01-27 11:56 ` [Qemu-devel] " Paolo Bonzini
2010-01-27 21:43 ` Anthony Liguori
2010-01-31 3:08 ` malc
2010-01-31 10:21 ` Paolo Bonzini
2010-01-27 2:09 ` [Qemu-devel] [PATCH 0/6] fix a few clang warnings Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5FA08A.6090107@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).