From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZxMQ-00019V-Q3
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:10:26 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZxMM-00018D-Rx
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:10:26 -0500
Received: from [199.232.76.173] (port=59911 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZxMM-000187-Kp
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:10:22 -0500
Received: from mail-iw0-f188.google.com ([209.85.223.188]:42042)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NZxMM-0000lT-B7
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 21:10:22 -0500
Received: by iwn26 with SMTP id 26so5639882iwn.14
	for <qemu-devel@nongnu.org>; Tue, 26 Jan 2010 18:10:21 -0800 (PST)
Message-ID: <4B5FA08A.6090107@codemonkey.ws>
Date: Tue, 26 Jan 2010 20:10:18 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 4/6] vnc.c: warn about ignored option
References: <1264547685-21129-1-git-send-email-pbonzini@redhat.com>
	<1264547685-21129-5-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1264547685-21129-5-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/26/2010 05:14 PM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   vnc.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/vnc.c b/vnc.c
> index cc2a26e..9ebee09 100644
> --- a/vnc.c
> +++ b/vnc.c
> @@ -2563,6 +2563,7 @@ int vnc_display_open(DisplayState *ds, const char *display)
>               reverse = 1;
>           } else if (strncmp(options, "to=", 3) == 0) {
>               to_port = atoi(options+3) + 5900;
> +            fprintf(stderr, "qemu: warning: to= option for -vnc ignored\n");
>    

If we're ignoring it, why even have the code?  How did clang spot this?

Regards,

Anthony Liguori