From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Na4bE-0001u9-O5 for qemu-devel@nongnu.org; Wed, 27 Jan 2010 04:54:12 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Na4bA-0001r0-RH for qemu-devel@nongnu.org; Wed, 27 Jan 2010 04:54:12 -0500 Received: from [199.232.76.173] (port=47698 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Na4bA-0001ql-9a for qemu-devel@nongnu.org; Wed, 27 Jan 2010 04:54:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35198) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Na4b9-0002XW-JS for qemu-devel@nongnu.org; Wed, 27 Jan 2010 04:54:07 -0500 Message-ID: <4B600D32.9080008@redhat.com> Date: Wed, 27 Jan 2010 10:53:54 +0100 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] vnc_refresh: calling vnc_update_client might free vs References: <4B5F83B2.8060003@codemonkey.ws> In-Reply-To: <4B5F83B2.8060003@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Stefano Stabellini On 01/27/10 01:07, Anthony Liguori wrote: > On 01/25/2010 06:54 AM, Stefano Stabellini wrote: >> Hi all, >> this patch fixes another bug in vnc_refresh: calling vnc_update_client >> might cause vs to be free()ed, in this case we cannot access vs->next >> right after to examine the next item on the list. >> >> Signed-off-by: Stefano Stabellini > > Applied. Thanks. IMHO this should go to stable too. cheers, Gerd