From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Na8ZH-0006ZY-1Q
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 09:08:27 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Na8ZC-0006YI-Cx
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 09:08:26 -0500
Received: from [199.232.76.173] (port=37364 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Na8ZC-0006YF-9s
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 09:08:22 -0500
Received: from mail-yw0-f179.google.com ([209.85.211.179]:45019)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Na8ZB-0006UZ-SB
	for qemu-devel@nongnu.org; Wed, 27 Jan 2010 09:08:22 -0500
Received: by ywh9 with SMTP id 9so5173299ywh.19
	for <qemu-devel@nongnu.org>; Wed, 27 Jan 2010 06:08:21 -0800 (PST)
Message-ID: <4B6048D3.6020001@codemonkey.ws>
Date: Wed, 27 Jan 2010 08:08:19 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] vnc_refresh: calling vnc_update_client might
	free vs
References: <alpine.DEB.2.00.1001251210570.7512@kaball-desktop>
	<4B5F83B2.8060003@codemonkey.ws> <4B600D32.9080008@redhat.com>
	<alpine.DEB.2.00.1001271229280.18353@kaball-desktop>
In-Reply-To: <alpine.DEB.2.00.1001271229280.18353@kaball-desktop>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 01/27/2010 06:29 AM, Stefano Stabellini wrote:
> On Wed, 27 Jan 2010, Gerd Hoffmann wrote:
>    
>> On 01/27/10 01:07, Anthony Liguori wrote:
>>      
>>> On 01/25/2010 06:54 AM, Stefano Stabellini wrote:
>>>        
>>>> Hi all,
>>>> this patch fixes another bug in vnc_refresh: calling vnc_update_client
>>>> might cause vs to be free()ed, in this case we cannot access vs->next
>>>> right after to examine the next item on the list.
>>>>
>>>> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
>>>>          
>>> Applied. Thanks.
>>>        
>> IMHO this should go to stable too.
>>
>>      
> Yes, good idea.
>    

Already did.

Regards,

Anthony Liguori