From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NaXUo-0008HM-MI
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 11:45:30 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NaXUk-0008BL-VW
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 11:45:30 -0500
Received: from [199.232.76.173] (port=52140 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NaXUk-0008BH-Gk
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 11:45:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:48653)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <john.cooper@redhat.com>) id 1NaXUj-0007Ao-QU
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 11:45:26 -0500
Message-ID: <4B61BD97.4020202@redhat.com>
Date: Thu, 28 Jan 2010 11:38:47 -0500
From: john cooper <john.cooper@redhat.com>
MIME-Version: 1.0
References: <20100128124327.GA32288@lst.de>
In-Reply-To: <20100128124327.GA32288@lst.de>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: future of the virtio-blk serial number support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, john.cooper@redhat.com, Rusty Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>

Christoph Hellwig wrote:
> Back iSeptember 2007 Michael made the serial number support in qemu
> optional and off by default, and in October 2009 Rusty reverted the
> Linux virtio-blk support for it.  Given that I can't find support in
> any other virtio implementation that makes the feature look essentially
> dead.
> 
> How should we proceed with adding more fields to struct virtio_blk_config?
> I would suggest removing the identity field, declaring
> VIRTIO_BLK_F_IDENTIFY officially deprecated and adding the new fields
> directly after blk_size again, maybe with a comment that these new
> features can't be advertized together with VIRTIO_BLK_F_IDENTIFY.

Agreed.  Feel free to remove it from the PCI
config space.  Its an artifact at this point
and I wouldn't even worry about deprecating
it. 

-john

-- 
john.cooper@redhat.com