From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/8] QError: Add QMP mode-oriented errors
Date: Thu, 28 Jan 2010 16:49:00 -0600 [thread overview]
Message-ID: <4B62145C.5060809@codemonkey.ws> (raw)
In-Reply-To: <1264686180-29845-4-git-send-email-lcapitulino@redhat.com>
On 01/28/2010 07:42 AM, Luiz Capitulino wrote:
> Two new errors:
>
> - QERR_QMP_INVALID_MODE_NAME
> - QERR_QMP_INVALID_MODE_TRANSITION
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> ---
> qerror.c | 8 ++++++++
> qerror.h | 6 ++++++
> 2 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/qerror.c b/qerror.c
> index 6c2aba0..d01354d 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -113,6 +113,14 @@ static const QErrorStringTable qerror_table[] = {
> .desc = "Bad QMP input object",
> },
> {
> + .error_fmt = QERR_QMP_INVALID_MODE_NAME,
> + .desc = "Mode name %(name) is invalid",
> + },
>
This is basically, invalid parameter, no?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2010-01-28 22:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 13:42 [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 1/8] QMP: Initial mode-oriented support Luiz Capitulino
2010-02-01 17:08 ` Markus Armbruster
2010-01-28 13:42 ` [Qemu-devel] [PATCH 2/8] QMP: Introduce 'query-qmp-mode' command Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 3/8] QError: Add QMP mode-oriented errors Luiz Capitulino
2010-01-28 22:49 ` Anthony Liguori [this message]
2010-01-29 0:38 ` Luiz Capitulino
2010-02-01 17:03 ` Markus Armbruster
2010-01-28 13:42 ` [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command Luiz Capitulino
2010-02-01 17:04 ` Markus Armbruster
2010-02-01 18:11 ` Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 5/8] QMP: Introduce qmp_capability_enable/disable Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 6/8] Monitor: Introduce find_info_cmd() Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 7/8] QMP: Enable feature negotiation support Luiz Capitulino
2010-01-28 13:43 ` [Qemu-devel] [PATCH 8/8] QMP: spec: Feature negotiation related changes Luiz Capitulino
2010-02-01 17:08 ` [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support Markus Armbruster
2010-02-01 18:22 ` Luiz Capitulino
2010-02-01 19:37 ` Markus Armbruster
2010-02-01 19:50 ` Luiz Capitulino
2010-02-02 8:03 ` Markus Armbruster
2010-02-02 12:12 ` Luiz Capitulino
2010-02-02 14:48 ` Markus Armbruster
2010-02-03 18:34 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B62145C.5060809@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).