From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NadAs-0008Cl-Qy
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 17:49:18 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NadAo-0008Bx-9V
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 17:49:18 -0500
Received: from [199.232.76.173] (port=52770 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NadAo-0008Bs-3X
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 17:49:14 -0500
Received: from mail-iw0-f188.google.com ([209.85.223.188]:38967)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NadAn-0001Ah-Db
	for qemu-devel@nongnu.org; Thu, 28 Jan 2010 17:49:13 -0500
Received: by iwn26 with SMTP id 26so1602080iwn.14
	for <qemu-devel@nongnu.org>; Thu, 28 Jan 2010 14:49:12 -0800 (PST)
Message-ID: <4B62145C.5060809@codemonkey.ws>
Date: Thu, 28 Jan 2010 16:49:00 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/8] QError: Add QMP mode-oriented errors
References: <1264686180-29845-1-git-send-email-lcapitulino@redhat.com>
	<1264686180-29845-4-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1264686180-29845-4-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/28/2010 07:42 AM, Luiz Capitulino wrote:
> Two new errors:
>
> - QERR_QMP_INVALID_MODE_NAME
> - QERR_QMP_INVALID_MODE_TRANSITION
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> ---
>   qerror.c |    8 ++++++++
>   qerror.h |    6 ++++++
>   2 files changed, 14 insertions(+), 0 deletions(-)
>
> diff --git a/qerror.c b/qerror.c
> index 6c2aba0..d01354d 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -113,6 +113,14 @@ static const QErrorStringTable qerror_table[] = {
>           .desc      = "Bad QMP input object",
>       },
>       {
> +        .error_fmt = QERR_QMP_INVALID_MODE_NAME,
> +        .desc      = "Mode name %(name) is invalid",
> +    },
>    

This is basically, invalid parameter, no?

Regards,

Anthony Liguori