From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NawNI-00033L-M1 for qemu-devel@nongnu.org; Fri, 29 Jan 2010 14:19:24 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NawNH-00032d-9d for qemu-devel@nongnu.org; Fri, 29 Jan 2010 14:19:23 -0500 Received: from [199.232.76.173] (port=54874 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NawNH-00032T-2z for qemu-devel@nongnu.org; Fri, 29 Jan 2010 14:19:23 -0500 Received: from are.twiddle.net ([75.149.56.221]:58276) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NawNG-0007jK-24 for qemu-devel@nongnu.org; Fri, 29 Jan 2010 14:19:22 -0500 Message-ID: <4B6334B8.9040002@twiddle.net> Date: Fri, 29 Jan 2010 11:19:20 -0800 From: Richard Henderson MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Porting TCG to alpha platform References: <242393.28161.qm@web15901.mail.cnb.yahoo.com> <4B5E4311.10707@twiddle.net> In-Reply-To: <4B5E4311.10707@twiddle.net> Content-Type: multipart/mixed; boundary="------------060206080003060908090209" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: identifier scorpio Cc: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------060206080003060908090209 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > + } else if (cond == TCG_COND_EQ || cond == TCG_COND_NE) { > + tcg_out_mem_long(s, INSN_LDA, TMP_REG1, arg1, -arg2); > + opc = (cond == TCG_COND_EQ ? INSN_BEQ : INSN_BNE); Bug here. What was intended was to add "arg1 = TMP_REG1". But since the constraints use "I" for uint8_t input constants, we might as well remove this hunk entirely. Also, let's future-proof this routine against changes to the layout of the TCGCond enumeration. r~ --------------060206080003060908090209 Content-Type: text/plain; name="commit-9d78757" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="commit-9d78757" Y29tbWl0IDlkNzg3NTc2MzQyYzE5M2YxM2UyNTMxOTUzZmM4MTQ0MjQ1OGRlN2UKQXV0aG9y OiBSaWNoYXJkIEhlbmRlcnNvbiA8cnRoQHR3aWRkbGUubmV0PgpEYXRlOiAgIEZyaSBKYW4g MjkgMTE6MTQ6MjAgMjAxMCAtMDgwMAoKICAgIHRjZy1hbHBoYTogRml4IEVRL05FIHdpdGgg YSBjb25zdGFudC4KICAgIAogICAgVGhlcmUgd2FzIHN0YXJ0IG9mIGNvZGUgdG8gaGFuZGxl IEVRIGFuZCBORSB3aXRoIGFyYml0cmFyeSBjb25zdGFudHMsCiAgICBidXQgaXQgd2Fzbid0 IGNvbXBsZXRlZC4gIFJlbW92ZSB0aGUgaGFsZi1kb25lIGNvZGUgYW5kIGFkZCBhIGNvbW1l bnQKICAgIGZvciBmdXR1cmUgZW5oYW5jZW1lbnRzLgogICAgCiAgICBBbHNvLCBkb24ndCBy ZWx5IG9uIHRoZSBjdXJyZW50IGxheW91dCBvZiBUQ0dDb25kOyBpbnN0ZWFkIGVuY29kZSB0 aGUKICAgIG5lZWQgZm9yIGludmVyc2lvbiBvZiB0aGUgY29tcGFyZSBpbnNuIHJlc3VsdCBi eSBtZWFucyBvZiBhIGxvdyBiaXQgc2V0CiAgICBpbiB0aGUgY21wX29wYyB0YWJsZS4gIFJl ZHVjZSB0aGUgZWxlbWVudCBzaXplIG9mIGNtcF9vcGMuCgpkaWZmIC0tZ2l0IGEvdGNnL2Fs cGhhL3RjZy10YXJnZXQuYyBiL3RjZy9hbHBoYS90Y2ctdGFyZ2V0LmMKaW5kZXggNWI3ZGQy NS4uMThhYjJjOCAxMDA2NDQKLS0tIGEvdGNnL2FscGhhL3RjZy10YXJnZXQuYworKysgYi90 Y2cvYWxwaGEvdGNnLXRhcmdldC5jCkBAIC01NDAsOSArNTQwLDExIEBAIHN0YXRpYyB2b2lk IHRjZ19vdXRfYnIoVENHQ29udGV4dCAqcywgaW50IG9wYywgaW50IHJhLCBpbnQgbGFiZWxf aW5kZXgpCiAgICAgdGNnX291dF9mbXRfYnIocywgb3BjLCByYSwgdmFsdWUpOwogfQogCi1z dGF0aWMgdm9pZCB0Y2dfb3V0X2JyY29uZChUQ0dDb250ZXh0ICpzLCBpbnQgY29uZCwgVENH QXJnIGFyZzEsCitzdGF0aWMgdm9pZCB0Y2dfb3V0X2JyY29uZChUQ0dDb250ZXh0ICpzLCBU Q0dDb25kIGNvbmQsIFRDR0FyZyBhcmcxLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg VENHQXJnIGFyZzIsIGludCBjb25zdF9hcmcyLCBpbnQgbGFiZWxfaW5kZXgpCiB7CisgICAg LyogTm90ZSB0aGF0IHVuc2lnbmVkIGNvbXBhcmlzb25zIGFyZSBub3QgcHJlc2VudCBoZXJl LCB3aGljaCBtZWFucworICAgICAgIHRoYXQgdGhlaXIgZW50cmllcyB3aWxsIGNvbnRhaW4g emVyb3MuICAqLwogICAgIHN0YXRpYyBjb25zdCBpbnQgYnJfb3BjWzEwXSA9IHsKICAgICAg ICAgW1RDR19DT05EX0VRXSA9IElOU05fQkVRLAogICAgICAgICBbVENHX0NPTkRfTkVdID0g SU5TTl9CTkUsCkBAIC01NTIsMzggKzU1NCw1NiBAQCBzdGF0aWMgdm9pZCB0Y2dfb3V0X2Jy Y29uZChUQ0dDb250ZXh0ICpzLCBpbnQgY29uZCwgVENHQXJnIGFyZzEsCiAgICAgICAgIFtU Q0dfQ09ORF9HVF0gPSBJTlNOX0JHVAogICAgIH07CiAKLSAgICBzdGF0aWMgY29uc3QgdWlu dDY0X3QgY21wX29wY1sxMF0gPSB7CisgICAgLyogVGhlIGxvdyBiaXQgb2YgdGhlc2UgZW50 cmllcyBpbmRpY2F0ZXMgdGhhdCB0aGUgcmVzdWx0IG9mIAorICAgICAgIHRoZSBjb21wYXJp c29uIG11c3QgYmUgaW52ZXJ0ZWQuICBUaGlzIGJpdCBzaG91bGQgbm90IGJlCisgICAgICAg b3V0cHV0IHdpdGggdGhlIHJlc3Qgb2YgdGhlIGluc3RydWN0aW9uLiAgKi8KKyAgICBzdGF0 aWMgY29uc3QgaW50IGNtcF9vcGNbMTBdID0gewogICAgICAgICBbVENHX0NPTkRfRVFdID0g SU5TTl9DTVBFUSwKLSAgICAgICAgW1RDR19DT05EX05FXSA9IElOU05fQ01QRVEsCisgICAg ICAgIFtUQ0dfQ09ORF9ORV0gPSBJTlNOX0NNUEVRIHwgMSwKICAgICAgICAgW1RDR19DT05E X0xUXSA9IElOU05fQ01QTFQsCi0gICAgICAgIFtUQ0dfQ09ORF9HRV0gPSBJTlNOX0NNUExU LAorICAgICAgICBbVENHX0NPTkRfR0VdID0gSU5TTl9DTVBMVCB8IDEsCiAgICAgICAgIFtU Q0dfQ09ORF9MRV0gPSBJTlNOX0NNUExFLAotICAgICAgICBbVENHX0NPTkRfR1RdID0gSU5T Tl9DTVBMRSwKKyAgICAgICAgW1RDR19DT05EX0dUXSA9IElOU05fQ01QTEUgfCAxLAogICAg ICAgICBbVENHX0NPTkRfTFRVXSA9IElOU05fQ01QVUxULAotICAgICAgICBbVENHX0NPTkRf R0VVXSA9IElOU05fQ01QVUxULAorICAgICAgICBbVENHX0NPTkRfR0VVXSA9IElOU05fQ01Q VUxUIHwgMSwKICAgICAgICAgW1RDR19DT05EX0xFVV0gPSBJTlNOX0NNUFVMRSwKLSAgICAg ICAgW1RDR19DT05EX0dUVV0gPSBJTlNOX0NNUFVMRQorICAgICAgICBbVENHX0NPTkRfR1RV XSA9IElOU05fQ01QVUxFIHwgMQogICAgIH07CiAKICAgICBpbnQgb3BjID0gMDsKIAotICAg IGlmIChjb25zdF9hcmcyKSB7Ci0gICAgICAgIGlmIChhcmcyID09IDApIHsKLSAgICAgICAg ICAgIG9wYyA9IGJyX29wY1tjb25kXTsKLSAgICAgICAgfSBlbHNlIGlmIChjb25kID09IFRD R19DT05EX0VRIHx8IGNvbmQgPT0gVENHX0NPTkRfTkUpIHsKLSAgICAgICAgICAgIHRjZ19v dXRfbWVtX2xvbmcocywgSU5TTl9MREEsIFRNUF9SRUcxLCBhcmcxLCAtYXJnMik7Ci0gICAg ICAgICAgICBvcGMgPSAoY29uZCA9PSBUQ0dfQ09ORF9FUSA/IElOU05fQkVRIDogSU5TTl9C TkUpOwotICAgICAgICB9CisgICAgLyogUG9zc2libGUgaW1wcm92ZW1lbnRzOgorICAgICAg ICgxKSBOb3RpY2UgYXJnMSA9PSAkMzEgYW5kICFjb25zdF9hcmcyLiAgSW4gdGhpcyBjYXNl LCBzd2FwIHRoZQorICAgICAgIHR3byBvcGVyYW5kcyBhbmQgc3dhcCB0aGUgc2Vuc2Ugb2Yg dGhlIGNvbXBhcmlzb24gdG8gYWxsb3cgdGhlCisgICAgICAgdXNlIG9mIHRoZSBkaXJlY3Qg YnJhbmNoZXMuCisKKyAgICAgICAoMikgQWxsb3cgYXJiaXRyYXJ5IGNvbnN0YW50cy4gIFdl IGNhbiwgb24gb2NjYXNpb24sIGdlbmVyYXRlIG9uZQorICAgICAgIGxlc3MgaW5zdHJ1Y3Rp b24gaWYgd2UgY29tcHV0ZQorICAgICAgICAgICBUTVAgPSBBUkcxIC0gQ09OU1QKKyAgICAg ICBpbnN0ZWFkIG9mCisgICAgICAgICAgIFRNUCA9IEFSRzEgY21wIFRNUDIKKyAgICAgICB3 aGVyZSBUTVAyIGlzIHRoZSBjb25zdGFudCBsb2FkZWQgaW50byBhIHJlZ2lzdGVyIGJ5IGdl bmVyaWMgY29kZS4KKyAgICAgICBOb3RlIHRoYXQgZm9yIDY0LWJpdCBvcGVyYW5kcyB0aGlz IHdvcmtzIG9ubHkgZm9yIEVRIGFuZCBORS4gIEZvcgorICAgICAgIDMyLWJpdCBvcGVyYW5k cywgd2Ugd291bGQgbmVlZCB0byBlaXRoZXIgbGltaXQgdGhpcyB0byBzaWduZWQKKyAgICAg ICBjb21wYXJpc29ucyBvciBwcm9wZXJseSB6ZXJvLWV4dGVuZCB1bnNpZ25lZCBpbnB1dHMu ICBUaGUgcGF5b2ZmCisgICAgICAgaGVyZSBpc24ndCBncmVhdCB0aG91Z2g7IG11Y2ggbGVz cyB0aGFuKDEpLiAgKi8KKworICAgIC8qIE5vdGljZSBzaWduZWQgY29tcGFyaXNvbnMgdnMg emVyby4gIFRoZXNlIGFyZSBoYW5kbGVkIGJ5IHRoZQorICAgICAgIGJyYW5jaCBpbnN0cnVj dGlvbnMgZGlyZWN0bHkuICAqLworICAgIGlmIChjb25zdF9hcmcyICYmIGFyZzIgPT0gMCkg eworICAgICAgICBvcGMgPSBicl9vcGNbY29uZF07CiAgICAgfQogCisgICAgLyogT3RoZXJ3 aXNlLCBnZW5lcmF0ZSBhIGNvbXBhcmlzb24gaW50byBhIHRlbXBvcmFyeS4gICovCiAgICAg aWYgKG9wYyA9PSAwKSB7Ci0gICAgICAgIG9wYyA9IGNtcF9vcGNbY29uZF07CisgICAgICAg IG9wYyA9IGNtcF9vcGNbY29uZF0gJiB+MTsKICAgICAgICAgaWYgKGNvbnN0X2FyZzIpIHsK ICAgICAgICAgICAgIHRjZ19vdXRfZm10X29waShzLCBvcGMsIGFyZzEsIGFyZzIsIFRNUF9S RUcxKTsKICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIHRjZ19vdXRfZm10X29wcihz LCBvcGMsIGFyZzEsIGFyZzIsIFRNUF9SRUcxKTsKICAgICAgICAgfQotICAgICAgICBvcGMg PSAoY29uZCAmIDEpID8gSU5TTl9CRVEgOiBJTlNOX0JORTsKKworICAgICAgICBvcGMgPSAo Y21wX29wY1tjb25kXSAmIDEgPyBJTlNOX0JFUSA6IElOU05fQk5FKTsKICAgICAgICAgYXJn MSA9IFRNUF9SRUcxOwogICAgIH0KIAo= --------------060206080003060908090209--