qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification
Date: Fri, 29 Jan 2010 14:45:07 -0600	[thread overview]
Message-ID: <4B6348D3.8030808@codemonkey.ws> (raw)
In-Reply-To: <1264609339-24353-1-git-send-email-amit.shah@redhat.com>

On 01/27/2010 10:22 AM, Amit Shah wrote:
> This commit enables one to use multiple virtio-serial devices and to
> assign ports to arbitrary devices like this:
>
>    -device virtio-serial,id=foo -device virtio-serial,id=bar \
>    -device virtserialport,bus=foo.0,name=foo \
>    -device virtserialport,bus=bar.0,name=bar
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/virtio-serial-bus.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 403268f..ab456ea 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -445,8 +445,7 @@ static VirtIOSerialBus *virtser_bus_new(DeviceState *dev)
>   {
>       VirtIOSerialBus *bus;
>
> -    bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev,
> -                                                 "virtio-serial-bus"));
> +    bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev, NULL));
>       bus->qbus.allow_hotplug = 1;
>
>       return bus;
>    

      parent reply	other threads:[~2010-01-29 20:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27 16:22 [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification Amit Shah
2010-01-28 11:56 ` Markus Armbruster
2010-01-29 20:45 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B6348D3.8030808@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).