From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NaxiO-0004f6-TV
	for qemu-devel@nongnu.org; Fri, 29 Jan 2010 15:45:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NaxiJ-0004cz-Vl
	for qemu-devel@nongnu.org; Fri, 29 Jan 2010 15:45:16 -0500
Received: from [199.232.76.173] (port=33944 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NaxiJ-0004cf-MD
	for qemu-devel@nongnu.org; Fri, 29 Jan 2010 15:45:11 -0500
Received: from mail-iw0-f172.google.com ([209.85.223.172]:51279)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NaxiI-0001By-O3
	for qemu-devel@nongnu.org; Fri, 29 Jan 2010 15:45:10 -0500
Received: by iwn2 with SMTP id 2so1744601iwn.19
	for <qemu-devel@nongnu.org>; Fri, 29 Jan 2010 12:45:09 -0800 (PST)
Message-ID: <4B6348D3.8030808@codemonkey.ws>
Date: Fri, 29 Jan 2010 14:45:07 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation
	and allow for bus identification
References: <1264609339-24353-1-git-send-email-amit.shah@redhat.com>
In-Reply-To: <1264609339-24353-1-git-send-email-amit.shah@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

On 01/27/2010 10:22 AM, Amit Shah wrote:
> This commit enables one to use multiple virtio-serial devices and to
> assign ports to arbitrary devices like this:
>
>    -device virtio-serial,id=foo -device virtio-serial,id=bar \
>    -device virtserialport,bus=foo.0,name=foo \
>    -device virtserialport,bus=bar.0,name=bar
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/virtio-serial-bus.c |    3 +--
>   1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 403268f..ab456ea 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -445,8 +445,7 @@ static VirtIOSerialBus *virtser_bus_new(DeviceState *dev)
>   {
>       VirtIOSerialBus *bus;
>
> -    bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev,
> -                                                 "virtio-serial-bus"));
> +    bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev, NULL));
>       bus->qbus.allow_hotplug = 1;
>
>       return bus;
>