* [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification
@ 2010-01-27 16:22 Amit Shah
2010-01-28 11:56 ` Markus Armbruster
2010-01-29 20:45 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Amit Shah @ 2010-01-27 16:22 UTC (permalink / raw)
To: qemu-devel; +Cc: Amit Shah
This commit enables one to use multiple virtio-serial devices and to
assign ports to arbitrary devices like this:
-device virtio-serial,id=foo -device virtio-serial,id=bar \
-device virtserialport,bus=foo.0,name=foo \
-device virtserialport,bus=bar.0,name=bar
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/virtio-serial-bus.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 403268f..ab456ea 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw/virtio-serial-bus.c
@@ -445,8 +445,7 @@ static VirtIOSerialBus *virtser_bus_new(DeviceState *dev)
{
VirtIOSerialBus *bus;
- bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev,
- "virtio-serial-bus"));
+ bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev, NULL));
bus->qbus.allow_hotplug = 1;
return bus;
--
1.6.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification
2010-01-27 16:22 [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification Amit Shah
@ 2010-01-28 11:56 ` Markus Armbruster
2010-01-29 20:45 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2010-01-28 11:56 UTC (permalink / raw)
To: Amit Shah; +Cc: qemu-devel
Amit Shah <amit.shah@redhat.com> writes:
> This commit enables one to use multiple virtio-serial devices and to
> assign ports to arbitrary devices like this:
>
> -device virtio-serial,id=foo -device virtio-serial,id=bar \
> -device virtserialport,bus=foo.0,name=foo \
> -device virtserialport,bus=bar.0,name=bar
>
> Signed-off-by: Amit Shah <amit.shah@redhat.com>
Yes, please. Without this, all virtio-serial devices name their bus the
same, and you have to use something like bus=pci.0/foo/virtio-serial-bus
to refer to one.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification
2010-01-27 16:22 [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification Amit Shah
2010-01-28 11:56 ` Markus Armbruster
@ 2010-01-29 20:45 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2010-01-29 20:45 UTC (permalink / raw)
To: Amit Shah; +Cc: qemu-devel
On 01/27/2010 10:22 AM, Amit Shah wrote:
> This commit enables one to use multiple virtio-serial devices and to
> assign ports to arbitrary devices like this:
>
> -device virtio-serial,id=foo -device virtio-serial,id=bar \
> -device virtserialport,bus=foo.0,name=foo \
> -device virtserialport,bus=bar.0,name=bar
>
> Signed-off-by: Amit Shah<amit.shah@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> hw/virtio-serial-bus.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
> index 403268f..ab456ea 100644
> --- a/hw/virtio-serial-bus.c
> +++ b/hw/virtio-serial-bus.c
> @@ -445,8 +445,7 @@ static VirtIOSerialBus *virtser_bus_new(DeviceState *dev)
> {
> VirtIOSerialBus *bus;
>
> - bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev,
> - "virtio-serial-bus"));
> + bus = FROM_QBUS(VirtIOSerialBus, qbus_create(&virtser_bus_info, dev, NULL));
> bus->qbus.allow_hotplug = 1;
>
> return bus;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-29 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-27 16:22 [Qemu-devel] [PATCH] virtio-serial-bus: Fix bus initialisation and allow for bus identification Amit Shah
2010-01-28 11:56 ` Markus Armbruster
2010-01-29 20:45 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).